Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1376093 > unrolled thread
| Started by | Julien Grall <julien.grall@arm.com> |
|---|---|
| First post | 2016-04-11 17:40 +0200 |
| Last post | 2016-04-13 12:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " Julien Grall <julien.grall@arm.com> - 2016-04-11 17:40 +0200
Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-13 12:10 +0200
| From | Julien Grall <julien.grall@arm.com> |
|---|---|
| Date | 2016-04-11 17:40 +0200 |
| Subject | [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " |
| Message-ID | <rmM6v-87k-29@gated-at.bofh.it> |
Currently, most of the pr_* messages in the GICv3 driver don't have a
prefix. Add one to make clear where the messages come from.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
Changes in v6:
- Patch added
---
drivers/irqchip/irq-gic-v3.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 5b7d3c2..6dc6f03 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -15,6 +15,8 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
+#define pr_fmt(fmt) "GICv3: " fmt
+
#include <linux/acpi.h>
#include <linux/cpu.h>
#include <linux/cpu_pm.h>
--
1.9.1
[toc] | [next] | [standalone]
| From | Hanjun Guo <hanjun.guo@linaro.org> |
|---|---|
| Date | 2016-04-13 12:10 +0200 |
| Subject | Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " |
| Message-ID | <rnpUe-86v-9@gated-at.bofh.it> |
| In reply to | #1376093 |
On 2016/4/11 23:32, Julien Grall wrote: > Currently, most of the pr_* messages in the GICv3 driver don't have a > prefix. Add one to make clear where the messages come from. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > --- > Changes in v6: > - Patch added > --- > drivers/irqchip/irq-gic-v3.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 5b7d3c2..6dc6f03 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -15,6 +15,8 @@ > * along with this program. If not, see <http://www.gnu.org/licenses/>. > */ > > +#define pr_fmt(fmt) "GICv3: " fmt I don't think this patch is needed, as GICv3 and GICv2 will not be probed at the same time, did I miss something? Further more, there are prefixes in pr_fmt in this patch using GIC:, with your patch added, it will print: GIV3: GIC: ..... which is not a good idea. Thanks Hanjun
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web