Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: "

From	Hanjun Guo <hanjun.guo@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: "
Date	2016-04-13 12:10 +0200
Message-ID	<rnpUe-86v-9@gated-at.bofh.it> (permalink)
References	<rmM6u-87k-5@gated-at.bofh.it> <rmM6v-87k-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016/4/11 23:32, Julien Grall wrote:
> Currently, most of the pr_* messages in the GICv3 driver don't have a
> prefix.  Add one to make clear where the messages come from.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
>      Changes in v6:
>          - Patch added
> ---
>   drivers/irqchip/irq-gic-v3.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 5b7d3c2..6dc6f03 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -15,6 +15,8 @@
>    * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>    */
>
> +#define pr_fmt(fmt)	"GICv3: " fmt

I don't think this patch is needed, as GICv3 and GICv2 will
not be probed at the same time, did I miss something?

Further more, there are prefixes in pr_fmt in this
patch using GIC:, with your patch added, it will print:

GIV3: GIC: .....

which is not a good idea.

Thanks
Hanjun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " Julien Grall <julien.grall@arm.com> - 2016-04-11 17:40 +0200
  Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by  "GICv3: " Hanjun Guo <hanjun.guo@linaro.org> - 2016-04-13 12:10 +0200

csiph-web