Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1376702 > unrolled thread

Re: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()

Started byThierry Reding <thierry.reding@gmail.com>
First post2016-04-12 13:10 +0200
Last post2016-04-12 16:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to  pwm_set_period() Thierry Reding <thierry.reding@gmail.com> - 2016-04-12 13:10 +0200
    Re: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to  pwm_set_period() Lee Jones <lee.jones@linaro.org> - 2016-04-12 16:20 +0200
      Re: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to  pwm_set_period() Thierry Reding <thierry.reding@gmail.com> - 2016-04-12 16:30 +0200

#1376702 — Re: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()

FromThierry Reding <thierry.reding@gmail.com>
Date2016-04-12 13:10 +0200
SubjectRe: [PATCH v5 02/46] backlight: pwm_bl: remove useless call to pwm_set_period()
Message-ID<rn4mJ-6uB-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Wed, Mar 30, 2016 at 10:03:25PM +0200, Boris Brezillon wrote:
> The PWM period will be set when calling pwm_config. Remove this useless
> call to pwm_set_period(), which might mess up with the internal PWM state.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/video/backlight/pwm_bl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Thierry

[toc] | [next] | [standalone]


#1376847

FromLee Jones <lee.jones@linaro.org>
Date2016-04-12 16:20 +0200
Message-ID<rn7kC-eE-39@gated-at.bofh.it>
In reply to#1376702
On Tue, 12 Apr 2016, Thierry Reding wrote:

> On Wed, Mar 30, 2016 at 10:03:25PM +0200, Boris Brezillon wrote:
> > The PWM period will be set when calling pwm_config. Remove this useless
> > call to pwm_set_period(), which might mess up with the internal PWM state.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/video/backlight/pwm_bl.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Applied, thanks.

Applied?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]


#1376852

FromThierry Reding <thierry.reding@gmail.com>
Date2016-04-12 16:30 +0200
Message-ID<rn7ui-ky-11@gated-at.bofh.it>
In reply to#1376847

[Multipart message — attachments visible in raw view] — view raw

On Tue, Apr 12, 2016 at 03:16:53PM +0100, Lee Jones wrote:
> On Tue, 12 Apr 2016, Thierry Reding wrote:
> 
> > On Wed, Mar 30, 2016 at 10:03:25PM +0200, Boris Brezillon wrote:
> > > The PWM period will be set when calling pwm_config. Remove this useless
> > > call to pwm_set_period(), which might mess up with the internal PWM state.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  drivers/video/backlight/pwm_bl.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > Applied, thanks.
> 
> Applied?

You Acked it, so I assumed you were fine with me taking it through the
PWM tree to take care of the dependencies.

Did I assume wrongly?

Thierry

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web