Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1376768 > unrolled thread

[PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-04-12 14:50 +0200
    Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 16:10 +0200
      Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-04-13 06:40 +0200

#1376768 — [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

This patch adds device tree nodes for pdma0 and pdma1 controllers
found on exynos7 SoCs.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7.dtsi |   29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 93108f1..cfecbd4 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -538,6 +538,35 @@
 			clocks = <&clock_peric0 PCLK_PWM>;
 			clock-names = "timers";
 		};
+
+		amba {
+			compatible = "simple-bus";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+
+			pdma0: pdma@10E10000 {
+				compatible = "arm,pl330", "arm,primecell";
+				reg = <0x10E10000 0x1000>;
+				interrupts = <0 225 0>;
+				clocks = <&clock_fsys0 ACLK_PDMA0>;
+				clock-names = "apb_pclk";
+				#dma-cells = <1>;
+				#dma-channels = <8>;
+				#dma-requests = <32>;
+			};
+
+			pdma1: pdma@10EB0000 {
+				compatible = "arm,pl330", "arm,primecell";
+				reg = <0x10EB0000 0x1000>;
+				interrupts = <0 226 0>;
+				clocks = <&clock_fsys0 ACLK_PDMA1>;
+				clock-names = "apb_pclk";
+				#dma-cells = <1>;
+				#dma-channels = <8>;
+				#dma-requests = <32>;
+			};
+		};
 	};
 };
 
-- 
1.7.10.4

[toc] | [next] | [standalone]

#1376830

On 04/12/2016 02:49 PM, Alim Akhtar wrote:
> This patch adds device tree nodes for pdma0 and pdma1 controllers
> found on exynos7 SoCs.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7.dtsi |   29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 

I would prefer avoid adding all new stuff at the end because it is
conflict-prone. Alphabetical order or by address... but none of these
are used currently. How about putting it after 'gic' node?

Anyway the code looks fine:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1377502

Hi Krzysztof,

On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote:
> On 04/12/2016 02:49 PM, Alim Akhtar wrote:
>> This patch adds device tree nodes for pdma0 and pdma1 controllers
>> found on exynos7 SoCs.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>   arch/arm64/boot/dts/exynos/exynos7.dtsi |   29 +++++++++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>
>
> I would prefer avoid adding all new stuff at the end because it is
> conflict-prone. Alphabetical order or by address... but none of these
> are used currently. How about putting it after 'gic' node?
>
hmm....ok will send v2 with suggested changes.
Looks like other platforms also put it below 'gic'.

> Anyway the code looks fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web