Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7

From	Alim Akhtar <alim.akhtar@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7
Date	2016-04-13 06:40 +0200
Message-ID	<rnkKR-3va-3@gated-at.bofh.it> (permalink)
References	<rn5Vw-7xe-13@gated-at.bofh.it> <rn7aX-al-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote:
> On 04/12/2016 02:49 PM, Alim Akhtar wrote:
>> This patch adds device tree nodes for pdma0 and pdma1 controllers
>> found on exynos7 SoCs.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>>   arch/arm64/boot/dts/exynos/exynos7.dtsi |   29 +++++++++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>
>
> I would prefer avoid adding all new stuff at the end because it is
> conflict-prone. Alphabetical order or by address... but none of these
> are used currently. How about putting it after 'gic' node?
>
hmm....ok will send v2 with suggested changes.
Looks like other platforms also put it below 'gic'.

> Anyway the code looks fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-04-12 14:50 +0200
  Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-12 16:10 +0200
    Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Alim Akhtar <alim.akhtar@samsung.com> - 2016-04-13 06:40 +0200

csiph-web