Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1376682 > unrolled thread

[PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero

Back to article view | Back to linux.kernel

Contents

  [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero Alexander Potapenko <glider@google.com> - 2016-04-12 12:50 +0200
    Re: [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-04-13 11:00 +0200

#1376682 — [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero

There's actually no point in reserving the zero hash value.

Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 lib/stackdepot.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 654c9d8..9e0b031 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
 		goto fast_exit;
 
 	hash = hash_stack(trace->entries, trace->nr_entries);
-	/* Bad luck, we won't store this stack. */
-	if (hash == 0)
-		goto exit;
-
 	bucket = &stack_table[hash & STACK_HASH_MASK];
 
 	/*
-- 
2.8.0.rc3.226.g39d4020

[toc] | [next] | [standalone]

#1377666

2016-04-12 13:46 GMT+03:00 Alexander Potapenko <glider@google.com>:
> There's actually no point in reserving the zero hash value.
>
> Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---

No sign-off, poor changelog.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web