[PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero

From	Alexander Potapenko <glider@google.com>
Newsgroups	linux.kernel
Subject	[PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero
Date	2016-04-12 12:50 +0200
Message-ID	<rn43o-643-31@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There's actually no point in reserving the zero hash value.

Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 lib/stackdepot.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 654c9d8..9e0b031 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
 		goto fast_exit;
 
 	hash = hash_stack(trace->entries, trace->nr_entries);
-	/* Bad luck, we won't store this stack. */
-	if (hash == 0)
-		goto exit;
-
 	bucket = &stack_table[hash & STACK_HASH_MASK];
 
 	/*
-- 
2.8.0.rc3.226.g39d4020

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero Alexander Potapenko <glider@google.com> - 2016-04-12 12:50 +0200
  Re: [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-04-13 11:00 +0200

csiph-web