Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374713 > unrolled thread

[PATCH 1/2] tty: Remove unused TTY_NUMBER() macro

Started byPeter Hurley <peter@hurleysoftware.com>
First post2016-04-10 05:40 +0200
Last post2016-04-10 20:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 05:40 +0200
    [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 05:40 +0200
      Re: [PATCH 2/2] tty: Remove stale parameter comment Jiri Slaby <jslaby@suse.cz> - 2016-04-10 10:30 +0200
        Re: [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 20:50 +0200

#1374713 — [PATCH 1/2] tty: Remove unused TTY_NUMBER() macro

FromPeter Hurley <peter@hurleysoftware.com>
Date2016-04-10 05:40 +0200
Subject[PATCH 1/2] tty: Remove unused TTY_NUMBER() macro
Message-ID<rmeo9-7hC-3@gated-at.bofh.it>
TTY_NUMBER() has been unused since v2.5.71; removed by
"[PATCH] callout removal: callout is gone".

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/tty_io.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 320dc4d..3cdd63b 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -230,9 +230,6 @@ static void tty_del_file(struct file *file)
 	tty_free_file(file);
 }
 
-
-#define TTY_NUMBER(tty) ((tty)->index + (tty)->driver->name_base)
-
 /**
  *	tty_name	-	return tty naming
  *	@tty: tty structure
-- 
2.8.1

[toc] | [next] | [standalone]

#1374714 — [PATCH 2/2] tty: Remove stale parameter comment

FromPeter Hurley <peter@hurleysoftware.com>
Date2016-04-10 05:40 +0200
Subject[PATCH 2/2] tty: Remove stale parameter comment
Message-ID<rmeo9-7hC-1@gated-at.bofh.it>
In reply to#1374713
noctty was removed as a parameter by commit 216513411937586
("tty: Consolidate noctty check in tty_open()").

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/tty_io.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 3cdd63b..50979be 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
  *	tty_lookup_driver - lookup a tty driver for a given device file
  *	@device: device number
  *	@filp: file pointer to tty
- *	@noctty: set if the device should not become a controlling tty
  *	@index: index for the device in the @return driver
  *	@return: driver for this inode (with increased refcount)
  *
-- 
2.8.1

[toc] | [prev] | [next] | [standalone]

#1374726 — Re: [PATCH 2/2] tty: Remove stale parameter comment

FromJiri Slaby <jslaby@suse.cz>
Date2016-04-10 10:30 +0200
SubjectRe: [PATCH 2/2] tty: Remove stale parameter comment
Message-ID<rmiUO-284-5@gated-at.bofh.it>
In reply to#1374714
On 04/10/2016, 05:36 AM, Peter Hurley wrote:
> noctty was removed as a parameter by commit 216513411937586

It is actually 11e1d4aa4da.

> ("tty: Consolidate noctty check in tty_open()").
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  drivers/tty/tty_io.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 3cdd63b..50979be 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>   *	tty_lookup_driver - lookup a tty driver for a given device file
>   *	@device: device number
>   *	@filp: file pointer to tty
> - *	@noctty: set if the device should not become a controlling tty
>   *	@index: index for the device in the @return driver
>   *	@return: driver for this inode (with increased refcount)
>   *
> 


-- 
js
suse labs

[toc] | [prev] | [next] | [standalone]

#1374868 — Re: [PATCH 2/2] tty: Remove stale parameter comment

FromPeter Hurley <peter@hurleysoftware.com>
Date2016-04-10 20:50 +0200
SubjectRe: [PATCH 2/2] tty: Remove stale parameter comment
Message-ID<rmsAQ-Sh-71@gated-at.bofh.it>
In reply to#1374726
On 04/10/2016 01:24 AM, Jiri Slaby wrote:
> On 04/10/2016, 05:36 AM, Peter Hurley wrote:
>> noctty was removed as a parameter by commit 216513411937586
> 
> It is actually 11e1d4aa4da.

Right; not sure where that number came from.


> 
>> ("tty: Consolidate noctty check in tty_open()").
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>>  drivers/tty/tty_io.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3cdd63b..50979be 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>>   *	tty_lookup_driver - lookup a tty driver for a given device file
>>   *	@device: device number
>>   *	@filp: file pointer to tty
>> - *	@noctty: set if the device should not become a controlling tty
>>   *	@index: index for the device in the @return driver
>>   *	@return: driver for this inode (with increased refcount)
>>   *
>>
> 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web