Re: [PATCH 2/2] tty: Remove stale parameter comment

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] tty: Remove stale parameter comment
Date	2016-04-10 20:50 +0200
Message-ID	<rmsAQ-Sh-71@gated-at.bofh.it> (permalink)
References	<rmeo9-7hC-3@gated-at.bofh.it> <rmeo9-7hC-1@gated-at.bofh.it> <rmiUO-284-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/10/2016 01:24 AM, Jiri Slaby wrote:
> On 04/10/2016, 05:36 AM, Peter Hurley wrote:
>> noctty was removed as a parameter by commit 216513411937586
> 
> It is actually 11e1d4aa4da.

Right; not sure where that number came from.


> 
>> ("tty: Consolidate noctty check in tty_open()").
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>>  drivers/tty/tty_io.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3cdd63b..50979be 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>>   *	tty_lookup_driver - lookup a tty driver for a given device file
>>   *	@device: device number
>>   *	@filp: file pointer to tty
>> - *	@noctty: set if the device should not become a controlling tty
>>   *	@index: index for the device in the @return driver
>>   *	@return: driver for this inode (with increased refcount)
>>   *
>>
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] tty: Remove unused TTY_NUMBER() macro Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 05:40 +0200
  [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 05:40 +0200
    Re: [PATCH 2/2] tty: Remove stale parameter comment Jiri Slaby <jslaby@suse.cz> - 2016-04-10 10:30 +0200
      Re: [PATCH 2/2] tty: Remove stale parameter comment Peter Hurley <peter@hurleysoftware.com> - 2016-04-10 20:50 +0200

csiph-web