Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371474 > unrolled thread

Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager  and glue code Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-05 14:10 +0200
    RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager  and glue code "Yu, Fenghua" <fenghua.yu@intel.com> - 2016-04-08 20:40 +0200

#1371474 — Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@linux.intel.com wrote:
> From: Megha Dey <megha.dey@intel.com>
> 
> This patch introduces the multi-buffer job manager which is responsible for
> submitting scatter-gather buffers from several SHA256 jobs to the
> multi-buffer algorithm. It also contains the flush routine to that's
> called by the crypto daemon to complete the job when no new jobs arrive
> before the deadline of maximum latency of a SHA256 crypto job.
> 
> The SHA256 multi-buffer crypto algorithm is defined and initialized in
> this patch.
> 
> Signed-off-by: Megha Dey <megha.dey@linux.intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>

sha1-mb still has the same issues that I complained about for the
aes-mb submission.  In particular, I don't like the use of shash
to handle what is really an async implmentation.

So I'd like to see this fixed first before we add any more copies
of this code.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [next] | [standalone]

#1374414

> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Tuesday, April 05, 2016 5:04 AM
> To: megha.dey@linux.intel.com
> Cc: davem@davemloft.net; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org; tim.c.chen@linux.intel.com; Yu, Fenghua
> <fenghua.yu@intel.com>; Dey, Megha <megha.dey@intel.com>
> Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job
> manager and glue code
> 
> On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@linux.intel.com
> wrote:
> > From: Megha Dey <megha.dey@intel.com>
> >
> > This patch introduces the multi-buffer job manager which is
> > responsible for submitting scatter-gather buffers from several SHA256
> > jobs to the multi-buffer algorithm. It also contains the flush routine
> > to that's called by the crypto daemon to complete the job when no new
> > jobs arrive before the deadline of maximum latency of a SHA256 crypto job.
> >
> > The SHA256 multi-buffer crypto algorithm is defined and initialized in
> > this patch.
> >
> > Signed-off-by: Megha Dey <megha.dey@linux.intel.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> > Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
> 
> sha1-mb still has the same issues that I complained about for the aes-mb
> submission.  In particular, I don't like the use of shash to handle what is really
> an async implmentation.
> 
> So I'd like to see this fixed first before we add any more copies of this code.

We will update the patches and re-send out sha1/256/512 AVX2 mb algos using async implementation.

Thanks.

-Fenghua

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web