RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

From	"Yu, Fenghua" <fenghua.yu@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code
Date	2016-04-08 20:40 +0200
Message-ID	<rlJu3-86Z-33@gated-at.bofh.it> (permalink)
References	<rgk3f-7Xs-3@gated-at.bofh.it> <rgk3h-7Xs-21@gated-at.bofh.it> <rkxXZ-36a-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Tuesday, April 05, 2016 5:04 AM
> To: megha.dey@linux.intel.com
> Cc: davem@davemloft.net; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org; tim.c.chen@linux.intel.com; Yu, Fenghua
> <fenghua.yu@intel.com>; Dey, Megha <megha.dey@intel.com>
> Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job
> manager and glue code
> 
> On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@linux.intel.com
> wrote:
> > From: Megha Dey <megha.dey@intel.com>
> >
> > This patch introduces the multi-buffer job manager which is
> > responsible for submitting scatter-gather buffers from several SHA256
> > jobs to the multi-buffer algorithm. It also contains the flush routine
> > to that's called by the crypto daemon to complete the job when no new
> > jobs arrive before the deadline of maximum latency of a SHA256 crypto job.
> >
> > The SHA256 multi-buffer crypto algorithm is defined and initialized in
> > this patch.
> >
> > Signed-off-by: Megha Dey <megha.dey@linux.intel.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> > Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
> 
> sha1-mb still has the same issues that I complained about for the aes-mb
> submission.  In particular, I don't like the use of shash to handle what is really
> an async implmentation.
> 
> So I'd like to see this fixed first before we add any more copies of this code.

We will update the patches and re-send out sha1/256/512 AVX2 mb algos using async implementation.

Thanks.

-Fenghua

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager  and glue code Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-05 14:10 +0200
  RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager  and glue code "Yu, Fenghua" <fenghua.yu@intel.com> - 2016-04-08 20:40 +0200

csiph-web