Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371187 > unrolled thread
| Started by | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| First post | 2016-04-05 06:40 +0200 |
| Last post | 2016-04-05 08:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH char-misc-linus] misc: mic: Fix randconfig build error Sudeep Dutt <sudeep.dutt@intel.com> - 2016-04-05 06:40 +0200
Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-05 06:50 +0200
Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Sudeep Dutt <sudeep.dutt@intel.com> - 2016-04-05 07:10 +0200
Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-05 08:10 +0200
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2016-04-05 06:40 +0200 |
| Subject | [PATCH char-misc-linus] misc: mic: Fix randconfig build error |
| Message-ID | <rkqWu-5Yd-5@gated-at.bofh.it> |
Fixes randconfig build error reported at https://lkml.org/lkml/2016/4/3/135 by ensuring that the VOP driver selects VIRTIO. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> --- drivers/misc/mic/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig index 2e4f3ba..89e5917 100644 --- a/drivers/misc/mic/Kconfig +++ b/drivers/misc/mic/Kconfig @@ -132,6 +132,7 @@ config VOP tristate "VOP Driver" depends on 64BIT && PCI && X86 && VOP_BUS select VHOST_RING + select VIRTIO help This enables VOP (Virtio over PCIe) Driver support for the Intel Many Integrated Core (MIC) family of PCIe form factor coprocessor -- 1.8.2.1
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-04-05 06:50 +0200 |
| Message-ID | <rkr69-61A-3@gated-at.bofh.it> |
| In reply to | #1371187 |
On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote: > Fixes randconfig build error reported at > https://lkml.org/lkml/2016/4/3/135 by ensuring that > the VOP driver selects VIRTIO. > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > --- > drivers/misc/mic/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig > index 2e4f3ba..89e5917 100644 > --- a/drivers/misc/mic/Kconfig > +++ b/drivers/misc/mic/Kconfig > @@ -132,6 +132,7 @@ config VOP > tristate "VOP Driver" > depends on 64BIT && PCI && X86 && VOP_BUS > select VHOST_RING > + select VIRTIO Shouldn't it depend on this instead? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Dutt <sudeep.dutt@intel.com> |
|---|---|
| Date | 2016-04-05 07:10 +0200 |
| Message-ID | <rkrpw-6ra-11@gated-at.bofh.it> |
| In reply to | #1371189 |
On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote: > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote: > > Fixes randconfig build error reported at > > https://lkml.org/lkml/2016/4/3/135 by ensuring that > > the VOP driver selects VIRTIO. > > > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > --- > > drivers/misc/mic/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig > > index 2e4f3ba..89e5917 100644 > > --- a/drivers/misc/mic/Kconfig > > +++ b/drivers/misc/mic/Kconfig > > @@ -132,6 +132,7 @@ config VOP > > tristate "VOP Driver" > > depends on 64BIT && PCI && X86 && VOP_BUS > > select VHOST_RING > > + select VIRTIO > > Shouldn't it depend on this instead? Hi Greg, The documentation for "config VIRTIO" states that "This option is selected by any driver which implements the virtio bus". I verified that this patch fixes the build for the randconfig which was failing earlier. Thanks, Sudeep Dutt
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-04-05 08:10 +0200 |
| Message-ID | <rkslA-7f1-17@gated-at.bofh.it> |
| In reply to | #1371206 |
On Mon, Apr 04, 2016 at 10:00:23PM -0700, Sudeep Dutt wrote: > On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote: > > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote: > > > Fixes randconfig build error reported at > > > https://lkml.org/lkml/2016/4/3/135 by ensuring that > > > the VOP driver selects VIRTIO. > > > > > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com> > > > --- > > > drivers/misc/mic/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig > > > index 2e4f3ba..89e5917 100644 > > > --- a/drivers/misc/mic/Kconfig > > > +++ b/drivers/misc/mic/Kconfig > > > @@ -132,6 +132,7 @@ config VOP > > > tristate "VOP Driver" > > > depends on 64BIT && PCI && X86 && VOP_BUS > > > select VHOST_RING > > > + select VIRTIO > > > > Shouldn't it depend on this instead? > > Hi Greg, > > The documentation for "config VIRTIO" states that "This option is > selected by any driver which implements the virtio bus". I verified that > this patch fixes the build for the randconfig which was failing earlier. Ah, you are right, nevermind, I'll queue this up soon... thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web