Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error
Date	2016-04-05 08:10 +0200
Message-ID	<rkslA-7f1-17@gated-at.bofh.it> (permalink)
References	<rkqWu-5Yd-5@gated-at.bofh.it> <rkr69-61A-3@gated-at.bofh.it> <rkrpw-6ra-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 04, 2016 at 10:00:23PM -0700, Sudeep Dutt wrote:
> On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote:
> > > Fixes randconfig build error reported at
> > > https://lkml.org/lkml/2016/4/3/135 by ensuring that
> > > the VOP driver selects VIRTIO.
> > > 
> > > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
> > > ---
> > >  drivers/misc/mic/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig
> > > index 2e4f3ba..89e5917 100644
> > > --- a/drivers/misc/mic/Kconfig
> > > +++ b/drivers/misc/mic/Kconfig
> > > @@ -132,6 +132,7 @@ config VOP
> > >  	tristate "VOP Driver"
> > >  	depends on 64BIT && PCI && X86 && VOP_BUS
> > >  	select VHOST_RING
> > > +	select VIRTIO
> > 
> > Shouldn't it depend on this instead?
> 
> Hi Greg,
> 
> The documentation for "config VIRTIO" states that "This option is
> selected by any driver which implements the virtio bus". I verified that
> this patch fixes the build for the randconfig which was failing earlier.

Ah, you are right, nevermind, I'll queue this up soon...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH char-misc-linus] misc: mic: Fix randconfig build error Sudeep Dutt <sudeep.dutt@intel.com> - 2016-04-05 06:40 +0200
  Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-05 06:50 +0200
    Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Sudeep Dutt <sudeep.dutt@intel.com> - 2016-04-05 07:10 +0200
      Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-05 08:10 +0200

csiph-web