Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371398 > unrolled thread

Re: [PATCH v3 0/5] davinci_mmc fixes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 0/5] davinci_mmc fixes Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-05 13:20 +0200
    Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:00 +0200
      Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:10 +0200
        Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:20 +0200

#1371398 — Re: [PATCH v3 0/5] davinci_mmc fixes

On 17 March 2016 at 04:45, David Lechner <david@lechnology.com> wrote:
> I have replaced one of my patches with the patch from Peter Ujfalusi and fixed
> a mistake in the "fix unwinding..." patch.
>
> Tested working on LEGO MINDSTORMS EV3 (da850-ish).
>
> David Lechner (4):
>   mmc: davinci: remove matching string
>   mmc: davinci: fix unwinding in probe
>   mmc: davinci: prepare clock
>   ARM: davinci: remove mmc dma resources
>
> Peter Ujfalusi (1):
>   mmc: davinci_mmc: Use dma_request_chan() to requesting DMA channel
>
>  arch/arm/mach-davinci/devices-da8xx.c |  20 -----
>  arch/arm/mach-davinci/devices.c       |  16 ----
>  drivers/mmc/host/davinci_mmc.c        | 147 ++++++++++++----------------------
>  3 files changed, 50 insertions(+), 133 deletions(-)
>
> --
> 1.9.1
>

Patch 3 triggers a compiler warning, please fix it.

../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
uninitialized in this function [-Wmaybe-uninitialized]

I have applied patch 1->2 for next, so no need to resend these.

Kind regards
Uffe

[toc] | [next] | [standalone]

#1371788

On 04/05/2016 06:12 AM, Ulf Hansson wrote:
>
> Patch 3 triggers a compiler warning, please fix it.
>
> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>
> I have applied patch 1->2 for next, so no need to resend these.
>
> Kind regards
> Uffe
>

I am not getting a compiler warning with this commit. Can you please 
provide a git link so that I can be sure I am building using the same 
branch that you are using?

[toc] | [prev] | [next] | [standalone]

#1371797

On 04/05/2016 11:51 AM, David Lechner wrote:
> On 04/05/2016 06:12 AM, Ulf Hansson wrote:
>>
>> Patch 3 triggers a compiler warning, please fix it.
>>
>> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
>> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>>
>> I have applied patch 1->2 for next, so no need to resend these.
>>
>> Kind regards
>> Uffe
>>
>
> I am not getting a compiler warning with this commit. Can you please
> provide a git link so that I can be sure I am building using the same
> branch that you are using?


I think I figured it out. I am applying the patches on top of the next 
branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However, I 
am still not getting a compiler warning. Perhaps it has to do with the 
gcc version. I'm not exactly sure how to fix it since it is really not 
used uninitialized. Just set it to 0 in the variable declaration?

[toc] | [prev] | [next] | [standalone]

#1371808

On 04/05/2016 12:07 PM, David Lechner wrote:
> On 04/05/2016 11:51 AM, David Lechner wrote:
>> On 04/05/2016 06:12 AM, Ulf Hansson wrote:
>>>
>>> Patch 3 triggers a compiler warning, please fix it.
>>>
>>> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
>>> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> I have applied patch 1->2 for next, so no need to resend these.
>>>
>>> Kind regards
>>> Uffe
>>>
>>
>> I am not getting a compiler warning with this commit. Can you please
>> provide a git link so that I can be sure I am building using the same
>> branch that you are using?
>
>
> I think I figured it out. I am applying the patches on top of the next
> branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However, I
> am still not getting a compiler warning. Perhaps it has to do with the
> gcc version. I'm not exactly sure how to fix it since it is really not
> used uninitialized. Just set it to 0 in the variable declaration?

OK. I guess it is my compiler that is broken. :-/
I stared at it long enough and I see the error now.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web