Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371808

Re: [PATCH v3 0/5] davinci_mmc fixes

Show all headers | View raw

On 04/05/2016 12:07 PM, David Lechner wrote:
> On 04/05/2016 11:51 AM, David Lechner wrote:
>> On 04/05/2016 06:12 AM, Ulf Hansson wrote:
>>>
>>> Patch 3 triggers a compiler warning, please fix it.
>>>
>>> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
>>> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> I have applied patch 1->2 for next, so no need to resend these.
>>>
>>> Kind regards
>>> Uffe
>>>
>>
>> I am not getting a compiler warning with this commit. Can you please
>> provide a git link so that I can be sure I am building using the same
>> branch that you are using?
>
>
> I think I figured it out. I am applying the patches on top of the next
> branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However, I
> am still not getting a compiler warning. Perhaps it has to do with the
> gcc version. I'm not exactly sure how to fix it since it is really not
> used uninitialized. Just set it to 0 in the variable declaration?

OK. I guess it is my compiler that is broken. :-/
I stared at it long enough and I see the error now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/5] davinci_mmc fixes Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-05 13:20 +0200
  Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:00 +0200
    Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:10 +0200
      Re: [PATCH v3 0/5] davinci_mmc fixes David Lechner <david@lechnology.com> - 2016-04-05 19:20 +0200

csiph-web