Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1371708 > unrolled thread

Re: [PATCH] iommu: change generic_device_group function

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] iommu: change generic_device_group function Joerg Roedel <joro@8bytes.org> - 2016-04-05 17:10 +0200

#1371708 — Re: [PATCH] iommu: change generic_device_group function

On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@126.com wrote:
> From: yalin wang <yalin.wang2010@gmail.com>
> 
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>

You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.


	Joerg

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web