Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1371708
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] iommu: change generic_device_group function |
| Date | 2016-04-05 17:10 +0200 |
| Message-ID | <rkAMb-5KI-27@gated-at.bofh.it> (permalink) |
| References | <rgzlD-1HA-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@126.com wrote: > From: yalin wang <yalin.wang2010@gmail.com> > > change this function to return only iommu_group* pointer or > PTR_ERR(), never return NULL when failed. > The caller of this function only check IS_ERR() for its return value. > > Signed-off-by: yalin wang <yalin.wang2010@gmail.com> You are right, thanks for catching this. But please leave the generic_device_group function in iommu.c. It is assigned to a function pointer by drivers, so inlining it doesn't make sense anyway. Joerg
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] iommu: change generic_device_group function Joerg Roedel <joro@8bytes.org> - 2016-04-05 17:10 +0200
csiph-web