Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369077 > unrolled thread

[PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit Minchan Kim <minchan@kernel.org> - 2016-04-01 10:00 +0200
    Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over  limit Michal Hocko <mhocko@kernel.org> - 2016-04-01 10:10 +0200
      Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is  over limit Andrew Morton <akpm@linux-foundation.org> - 2016-04-01 22:20 +0200
        Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over  limit Minchan Kim <minchan@kernel.org> - 2016-04-04 01:50 +0200

#1369077 — [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

We have been reclaimed highmem zone if buffer_heads is over limit
but [1] changed the behavior so it doesn't reclaim highmem zone
although buffer_heads is over the limit.
This patch restores the logic.

As well, [2] removed classzone_idx so we don't need code related to
it. This patch cleans it up.

[1] commit 6b4f7799c6a5 ("mm: vmscan: invoke slab shrinkers from shrink_zone()")
[2] commit 5acbd3bfc93b ("mm, oom: rework oom detection")

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/vmscan.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index c7696a2e11c7..6e67de2a61ed 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2550,17 +2550,9 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
 		sc->gfp_mask |= __GFP_HIGHMEM;
 
 	for_each_zone_zonelist_nodemask(zone, z, zonelist,
-					requested_highidx, sc->nodemask) {
-		enum zone_type classzone_idx;
-
+					gfp_zone(sc->gfp_mask), sc->nodemask) {
 		if (!populated_zone(zone))
 			continue;
-
-		classzone_idx = requested_highidx;
-		while (!populated_zone(zone->zone_pgdat->node_zones +
-							classzone_idx))
-			classzone_idx--;
-
 		/*
 		 * Take care memory controller reclaiming has small influence
 		 * to global LRU.
-- 
1.9.1

[toc] | [next] | [standalone]

#1369086 — Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

On Fri 01-04-16 17:00:58, Minchan Kim wrote:
[...]
> [2] commit 5acbd3bfc93b ("mm, oom: rework oom detection")

I didn't look a tht patch yet but wanted to note that this sha is most
probably from linux-next and won't be stable. Also this patch will most
likely see some changes in future so making changes on top which should
go in independetly will likely just complicate things.
-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1369572 — Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

On Fri, 1 Apr 2016 10:03:50 +0200 Michal Hocko <mhocko@kernel.org> wrote:

> On Fri 01-04-16 17:00:58, Minchan Kim wrote:
> [...]
> > [2] commit 5acbd3bfc93b ("mm, oom: rework oom detection")
> 
> I didn't look a tht patch yet but wanted to note that this sha is most
> probably from linux-next and won't be stable. Also this patch will most
> likely see some changes in future so making changes on top which should
> go in independetly will likely just complicate things.

Yes, we'll need two patches please.  One to fix 6b4f7799c6a5 ("mm:
vmscan: invoke slab shrinkers from shrink_zone()") (which is in
mainline) and a second to clean up -mm's "mm, oom: rework oom detection".

[toc] | [prev] | [next] | [standalone]

#1370315 — Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit

On Fri, Apr 01, 2016 at 01:14:58PM -0700, Andrew Morton wrote:
> On Fri, 1 Apr 2016 10:03:50 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> 
> > On Fri 01-04-16 17:00:58, Minchan Kim wrote:
> > [...]
> > > [2] commit 5acbd3bfc93b ("mm, oom: rework oom detection")
> > 
> > I didn't look a tht patch yet but wanted to note that this sha is most
> > probably from linux-next and won't be stable. Also this patch will most
> > likely see some changes in future so making changes on top which should
> > go in independetly will likely just complicate things.
> 
> Yes, we'll need two patches please.  One to fix 6b4f7799c6a5 ("mm:
> vmscan: invoke slab shrinkers from shrink_zone()") (which is in
> mainline) and a second to clean up -mm's "mm, oom: rework oom detection".

Andrew, Michal

Thanks. I just sent out it as separate patch.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web