Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367913 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-03-31 09:40 +0200 |
| Last post | 2016-04-04 01:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-31 09:40 +0200
Re: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Jaehoon Chung <jh80.chung@samsung.com> - 2016-04-01 02:30 +0200
Re: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Jaehoon Chung <jh80.chung@samsung.com> - 2016-04-04 01:50 +0200
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-03-31 09:40 +0200 |
| Subject | [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc |
| Message-ID | <riFmV-1xL-3@gated-at.bofh.it> |
Hello Jeahoon Currently dw_mmc is a little too queen-size. As we had cleanup prepare_command callback some days before, there are also some ones deserve to remove. Also we should avoid add new quirks or callbacks into dw_mmc in order to avoid the dilemma sdhci meets now. This patchset remove setup_clock callback. Obviously, add a callback just for one-time-used clk stuff make no sense. We combine what setup_clock does before into init callback. For exynos platfrom, it needs call init hook after resume, so we add new argument in init hook to indicate whether it needs do clk stuff or not. Changes in v2: - rebase on linux-mmc next - remove add setup_clk flag for init callback Shawn Lin (3): mmc: dw_mmc-rockchip: remove setup_clock for rockchip mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock mmc: dw_mmc: remove setup_clock callback drivers/mmc/host/dw_mmc-exynos.c | 8 -------- drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++-------- drivers/mmc/host/dw_mmc.c | 9 --------- drivers/mmc/host/dw_mmc.h | 2 -- 4 files changed, 4 insertions(+), 27 deletions(-) -- 2.3.7
[toc] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-04-01 02:30 +0200 |
| Message-ID | <riV8m-4z1-13@gated-at.bofh.it> |
| In reply to | #1367913 |
Hi, On 03/31/2016 04:33 PM, Shawn Lin wrote: > Hello Jeahoon > > Currently dw_mmc is a little too queen-size. As we had cleanup > prepare_command callback some days before, there are also some > ones deserve to remove. Also we should avoid add new quirks or > callbacks into dw_mmc in order to avoid the dilemma sdhci meets > now. > > This patchset remove setup_clock callback. Obviously, add a callback > just for one-time-used clk stuff make no sense. We combine what > setup_clock does before into init callback. For exynos platfrom, it > needs call init hook after resume, so we add new argument in init hook > to indicate whether it needs do clk stuff or not. Thanks for resending these. This message looks like previous message.. Anyway, i will pick you patch with my patch.. Best Regards, Jaehoon Chung > > > Changes in v2: > - rebase on linux-mmc next > - remove add setup_clk flag for init callback > > Shawn Lin (3): > mmc: dw_mmc-rockchip: remove setup_clock for rockchip > mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock > mmc: dw_mmc: remove setup_clock callback > > drivers/mmc/host/dw_mmc-exynos.c | 8 -------- > drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++-------- > drivers/mmc/host/dw_mmc.c | 9 --------- > drivers/mmc/host/dw_mmc.h | 2 -- > 4 files changed, 4 insertions(+), 27 deletions(-) >
[toc] | [prev] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-04-04 01:50 +0200 |
| Message-ID | <rjZWi-2AR-21@gated-at.bofh.it> |
| In reply to | #1367913 |
Hi, Picked this patch-set on my repository. Best Regards, Jaehoon Chung On 03/31/2016 04:33 PM, Shawn Lin wrote: > Hello Jeahoon > > Currently dw_mmc is a little too queen-size. As we had cleanup > prepare_command callback some days before, there are also some > ones deserve to remove. Also we should avoid add new quirks or > callbacks into dw_mmc in order to avoid the dilemma sdhci meets > now. > > This patchset remove setup_clock callback. Obviously, add a callback > just for one-time-used clk stuff make no sense. We combine what > setup_clock does before into init callback. For exynos platfrom, it > needs call init hook after resume, so we add new argument in init hook > to indicate whether it needs do clk stuff or not. > > > Changes in v2: > - rebase on linux-mmc next > - remove add setup_clk flag for init callback > > Shawn Lin (3): > mmc: dw_mmc-rockchip: remove setup_clock for rockchip > mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock > mmc: dw_mmc: remove setup_clock callback > > drivers/mmc/host/dw_mmc-exynos.c | 8 -------- > drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++-------- > drivers/mmc/host/dw_mmc.c | 9 --------- > drivers/mmc/host/dw_mmc.h | 2 -- > 4 files changed, 4 insertions(+), 27 deletions(-) >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web