Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367913

[PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc

Show all headers | View raw

Hello Jeahoon

Currently dw_mmc is a little too queen-size. As we had cleanup
prepare_command callback some days before, there are also some
ones deserve to remove. Also we should avoid add new quirks or
callbacks into dw_mmc in order to avoid the dilemma sdhci meets
now.

This patchset remove setup_clock callback. Obviously, add a callback
just for one-time-used clk stuff make no sense. We combine what
setup_clock does before into init callback. For exynos platfrom, it
needs call init hook after resume, so we add new argument in init hook
to indicate whether it needs do clk stuff or not.


Changes in v2:
- rebase on linux-mmc next
- remove add setup_clk flag for init callback

Shawn Lin (3):
  mmc: dw_mmc-rockchip: remove setup_clock for rockchip
  mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock
  mmc: dw_mmc: remove setup_clock callback

 drivers/mmc/host/dw_mmc-exynos.c   |  8 --------
 drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++--------
 drivers/mmc/host/dw_mmc.c          |  9 ---------
 drivers/mmc/host/dw_mmc.h          |  2 --
 4 files changed, 4 insertions(+), 27 deletions(-)

-- 
2.3.7

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-31 09:40 +0200
  Re: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Jaehoon Chung <jh80.chung@samsung.com> - 2016-04-01 02:30 +0200

csiph-web