Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1366822 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2016-03-30 02:50 +0200 |
| Last post | 2016-03-30 14:10 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 02:50 +0200
Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:10 +0200
Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:20 +0200
Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 10:30 +0200
Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 14:10 +0200
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-03-30 02:50 +0200 |
| Subject | [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| Message-ID | <ricuC-5QH-9@gated-at.bofh.it> |
The devres.o gets linked if HAS_IOMEM is present so on ARCH=um allyesconfig (COMPILE_TEST) failed with: drivers/built-in.o: In function `omap_control_phy_probe': phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' drivers/built-in.o: In function `cygnus_pcie_phy_probe': phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/phy/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 26566db09de0..879ac798f6f7 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2 config OMAP_CONTROL_PHY tristate "OMAP CONTROL PHY Driver" depends on ARCH_OMAP2PLUS || COMPILE_TEST + depends on HAS_IOMEM help Enable this to add support for the PHY part present in the control module. This driver has API to power on the USB2 PHY and to write to @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA config PHY_CYGNUS_PCIE tristate "Broadcom Cygnus PCIe PHY driver" depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST) + depends on HAS_IOMEM select GENERIC_PHY default ARCH_BCM_CYGNUS help -- 2.5.0
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-03-30 10:10 +0200 |
| Subject | Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| Message-ID | <rijmq-2uB-11@gated-at.bofh.it> |
| In reply to | #1366822 |
On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > allyesconfig (COMPILE_TEST) failed with: > > drivers/built-in.o: In function `omap_control_phy_probe': > phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > drivers/built-in.o: In function `cygnus_pcie_phy_probe': > phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/phy/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) Holding off on this until the discussion reaches some kind of consensus. > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 26566db09de0..879ac798f6f7 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2 > config OMAP_CONTROL_PHY > tristate "OMAP CONTROL PHY Driver" > depends on ARCH_OMAP2PLUS || COMPILE_TEST > + depends on HAS_IOMEM > help > Enable this to add support for the PHY part present in the control > module. This driver has API to power on the USB2 PHY and to write to > @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA > config PHY_CYGNUS_PCIE > tristate "Broadcom Cygnus PCIe PHY driver" > depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST) > + depends on HAS_IOMEM > select GENERIC_PHY > default ARCH_BCM_CYGNUS > help -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-03-30 10:20 +0200 |
| Subject | Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| Message-ID | <rijw6-2y5-23@gated-at.bofh.it> |
| In reply to | #1366974 |
On Wed, 30 Mar 2016, Lee Jones wrote: > On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > > > The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > > allyesconfig (COMPILE_TEST) failed with: > > > > drivers/built-in.o: In function `omap_control_phy_probe': > > phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > > drivers/built-in.o: In function `cygnus_pcie_phy_probe': > > phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/phy/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > Holding off on this until the discussion reaches some kind of > consensus. FYI: https://lkml.org/lkml/2016/3/29/716 > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 26566db09de0..879ac798f6f7 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2 > > config OMAP_CONTROL_PHY > > tristate "OMAP CONTROL PHY Driver" > > depends on ARCH_OMAP2PLUS || COMPILE_TEST > > + depends on HAS_IOMEM > > help > > Enable this to add support for the PHY part present in the control > > module. This driver has API to power on the USB2 PHY and to write to > > @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA > > config PHY_CYGNUS_PCIE > > tristate "Broadcom Cygnus PCIe PHY driver" > > depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST) > > + depends on HAS_IOMEM > > select GENERIC_PHY > > default ARCH_BCM_CYGNUS > > help > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-03-30 10:30 +0200 |
| Subject | Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| Message-ID | <rijFL-2CP-1@gated-at.bofh.it> |
| In reply to | #1366990 |
On 30.03.2016 17:10, Lee Jones wrote: > On Wed, 30 Mar 2016, Lee Jones wrote: > >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: >> >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um >>> allyesconfig (COMPILE_TEST) failed with: >>> >>> drivers/built-in.o: In function `omap_control_phy_probe': >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe': >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' >>> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> --- >>> drivers/phy/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Holding off on this until the discussion reaches some kind of >> consensus. > > FYI: https://lkml.org/lkml/2016/3/29/716 Yeah, I saw it today. But this is a little bit different. It is not caused by selecting MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM). Best regards, Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-03-30 14:10 +0200 |
| Subject | Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM |
| Message-ID | <rin6G-57W-1@gated-at.bofh.it> |
| In reply to | #1366994 |
On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > On 30.03.2016 17:10, Lee Jones wrote: > > On Wed, 30 Mar 2016, Lee Jones wrote: > > > >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > >> > >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > >>> allyesconfig (COMPILE_TEST) failed with: > >>> > >>> drivers/built-in.o: In function `omap_control_phy_probe': > >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe': > >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > >>> > >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >>> --- > >>> drivers/phy/Kconfig | 2 ++ > >>> 1 file changed, 2 insertions(+) > >> > >> Holding off on this until the discussion reaches some kind of > >> consensus. > > > > FYI: https://lkml.org/lkml/2016/3/29/716 > > Yeah, I saw it today. > > But this is a little bit different. It is not caused by selecting > MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM). Discussion is continuing. Please follow it until conclusion, then re-submit your patches (remembering to Cc the individuals in the aforementioned conversation). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web