Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
Date	2016-03-30 14:10 +0200
Message-ID	<rin6G-57W-1@gated-at.bofh.it> (permalink)
References	<ricuC-5QH-9@gated-at.bofh.it> <rijmq-2uB-11@gated-at.bofh.it> <rijw6-2y5-23@gated-at.bofh.it> <rijFL-2CP-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:

> On 30.03.2016 17:10, Lee Jones wrote:
> > On Wed, 30 Mar 2016, Lee Jones wrote:
> > 
> >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
> >>
> >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> >>> allyesconfig (COMPILE_TEST) failed with:
> >>>
> >>> drivers/built-in.o: In function `omap_control_phy_probe':
> >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
> >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
> >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>> ---
> >>>  drivers/phy/Kconfig | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>
> >> Holding off on this until the discussion reaches some kind of
> >> consensus.
> > 
> > FYI: https://lkml.org/lkml/2016/3/29/716
> 
> Yeah, I saw it today.
> 
> But this is a little bit different. It is not caused by selecting
> MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM).

Discussion is continuing.  Please follow it until conclusion, then
re-submit your patches (remembering to Cc the individuals in the
aforementioned conversation).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 02:50 +0200
  Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource  on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:10 +0200
    Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource  on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:20 +0200
      Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on  UM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 10:30 +0200
        Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource  on UM Lee Jones <lee.jones@linaro.org> - 2016-03-30 14:10 +0200

csiph-web