Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1365655 > unrolled thread
| Started by | Akshay Bhat <akshay.bhat@timesys.com> |
|---|---|
| First post | 2016-03-28 22:20 +0200 |
| Last post | 2016-04-01 03:50 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Akshay Bhat <akshay.bhat@timesys.com> - 2016-03-28 22:20 +0200
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-03-30 03:30 +0200
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Guenter Roeck <linux@roeck-us.net> - 2016-03-30 23:10 +0200
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-03-31 04:00 +0200
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Tim Harvey <tharvey@gateworks.com> - 2016-03-31 20:10 +0200
Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-04-01 03:50 +0200
| From | Akshay Bhat <akshay.bhat@timesys.com> |
|---|---|
| Date | 2016-03-28 22:20 +0200 |
| Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| Message-ID | <rhLNL-3BZ-1@gated-at.bofh.it> |
Hi Shawn, On 02/28/2016 08:56 AM, Fabio Estevam wrote: > Rob, > > On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > >>> I have no objections against the idea and the code itself. >>> But as Guenter pointed out: it would be handy to get feedback from the >>> devicetree maintainers on the above discussion. >>> >>> Kind regards, >>> Wim. >>> >> >> Any suggestions on whether a vendor specific prefix is necessary? > > Any comments? > Is this something you can help with, since you are the iMX architecture/devicetree maintainer? Appreciate any feedback. Thanks, Akshay
[toc] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-03-30 03:30 +0200 |
| Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| Message-ID | <rid7k-6mj-3@gated-at.bofh.it> |
| In reply to | #1365655 |
On Mon, Mar 28, 2016 at 04:19:15PM -0400, Akshay Bhat wrote: > Hi Shawn, > > On 02/28/2016 08:56 AM, Fabio Estevam wrote: > >Rob, > > > >On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > > > >>>I have no objections against the idea and the code itself. > >>>But as Guenter pointed out: it would be handy to get feedback from the > >>>devicetree maintainers on the above discussion. > >>> > >>>Kind regards, > >>>Wim. > >>> > >> > >>Any suggestions on whether a vendor specific prefix is necessary? > > > >Any comments? > > > > Is this something you can help with, since you are the iMX > architecture/devicetree maintainer? Appreciate any feedback. FWIW, Acked-by: Shawn Guo <shawnguo@kernel.org> Guenter, I think it's reasonable to pick up the patch, if we have it copied to DT maintainers and on the list for a long period of time, and do not see any objection from anyone. Shawn
[toc] | [prev] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-03-30 23:10 +0200 |
| Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| Message-ID | <rivxg-2LV-11@gated-at.bofh.it> |
| In reply to | #1366843 |
On Wed, Mar 30, 2016 at 09:22:33AM +0800, Shawn Guo wrote: > On Mon, Mar 28, 2016 at 04:19:15PM -0400, Akshay Bhat wrote: > > Hi Shawn, > > > > On 02/28/2016 08:56 AM, Fabio Estevam wrote: > > >Rob, > > > > > >On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote: > > > > > >>>I have no objections against the idea and the code itself. > > >>>But as Guenter pointed out: it would be handy to get feedback from the > > >>>devicetree maintainers on the above discussion. > > >>> > > >>>Kind regards, > > >>>Wim. > > >>> > > >> > > >>Any suggestions on whether a vendor specific prefix is necessary? > > > > > >Any comments? > > > > > > > Is this something you can help with, since you are the iMX > > architecture/devicetree maintainer? Appreciate any feedback. > > FWIW, > > Acked-by: Shawn Guo <shawnguo@kernel.org> > > Guenter, > > I think it's reasonable to pick up the patch, if we have it copied to DT > maintainers and on the list for a long period of time, and do not see > any objection from anyone. > The question was if the property name should be ext-reset-output or fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output because it is not a generic property. Tim disagrees. So we have two options: Change the property name to fsl,ext-reset-output, which I would accept, or wait for a devicetree maintainer to make a decision. Guenter
[toc] | [prev] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-03-31 04:00 +0200 |
| Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| Message-ID | <riA3T-5P1-5@gated-at.bofh.it> |
| In reply to | #1367612 |
On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > The question was if the property name should be ext-reset-output or > fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > because it is not a generic property. Tim disagrees. > > So we have two options: Change the property name to fsl,ext-reset-output, > which I would accept, or wait for a devicetree maintainer to make a decision. Guenter, I agree with you on this point. Before everyone agrees that this is a generic binding, we should have vendor prefix for the property. Tim, This is a small change which, IMO, shouldn't hold an useful patch from being merged. Care to resend with the suggested change? Shawn
[toc] | [prev] | [next] | [standalone]
| From | Tim Harvey <tharvey@gateworks.com> |
|---|---|
| Date | 2016-03-31 20:10 +0200 |
| Message-ID | <riPcC-uz-9@gated-at.bofh.it> |
| In reply to | #1367748 |
On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@kernel.org> wrote: > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: >> The question was if the property name should be ext-reset-output or >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output >> because it is not a generic property. Tim disagrees. >> Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer? >> So we have two options: Change the property name to fsl,ext-reset-output, >> which I would accept, or wait for a devicetree maintainer to make a decision. > > Guenter, > > I agree with you on this point. Before everyone agrees that this is a > generic binding, we should have vendor prefix for the property. > > Tim, > > This is a small change which, IMO, shouldn't hold an useful patch from being > merged. Care to resend with the suggested change? > > Shawn Shawn, Sure - I'll rebase and re-submit. Tim
[toc] | [prev] | [next] | [standalone]
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-04-01 03:50 +0200 |
| Subject | Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop |
| Message-ID | <riWnM-5qf-13@gated-at.bofh.it> |
| In reply to | #1368514 |
On Thu, Mar 31, 2016 at 11:01:58AM -0700, Tim Harvey wrote: > On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@kernel.org> wrote: > > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > >> The question was if the property name should be ext-reset-output or > >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > >> because it is not a generic property. Tim disagrees. > >> > > Guenter, > > My issue regarding the vendor prefix was not a hard dissagreement but > was more about me understanding the rational behind using vendor > prefixes. In this case the imx2_wdt driver 'is' a vendor specific > driver as its compatible strings are prefixed with 'fsl,' so isn't > 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt > inherently a vendor specific properly already? I assume that is why > the 'big-endian' property isn't 'fsl,big-endian'. We should read it as that 'big-endian' is a generic property defined by generic bindings - bindings/regmap/regmap.txt, and we just reference the bindings in fsl-imx-wdt.txt. Taking mmc bindings as example, bindings/mmc/mmc.txt defines generic bindings, while bindings/mmc/fsl-imx-esdhc.txt defines i.MX vendor specific properties, which should ideally have vendor prefix. Shawn
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web