Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368514

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

Show all headers | View raw

On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:
>> The question was if the property name should be ext-reset-output or
>> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output
>> because it is not a generic property. Tim disagrees.
>>

Guenter,

My issue regarding the vendor prefix was not a hard dissagreement but
was more about me understanding the rational behind using vendor
prefixes. In this case the imx2_wdt driver 'is' a vendor specific
driver as its compatible strings are prefixed with 'fsl,' so isn't
'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt
inherently a vendor specific properly already? I assume that is why
the 'big-endian' property isn't 'fsl,big-endian'.

Maybe it's more about if it 'is' marked as a vendor specific property
its much easier to get approval and accepted by a vendor-specific
maintainer?

>> So we have two options: Change the property name to fsl,ext-reset-output,
>> which I would accept, or wait for a devicetree maintainer to make a decision.
>
> Guenter,
>
> I agree with you on this point.  Before everyone agrees that this is a
> generic binding, we should have vendor prefix for the property.
>
> Tim,
>
> This is a small change which, IMO, shouldn't hold an useful patch from being
> merged.  Care to resend with the suggested change?
>
> Shawn

Shawn,

Sure - I'll rebase and re-submit.

Tim

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via  'ext-reset-output' dt prop Akshay Bhat <akshay.bhat@timesys.com> - 2016-03-28 22:20 +0200
  Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support  via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-03-30 03:30 +0200
    Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support  via 'ext-reset-output' dt prop Guenter Roeck <linux@roeck-us.net> - 2016-03-30 23:10 +0200
      Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support  via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-03-31 04:00 +0200
        Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via  'ext-reset-output' dt prop Tim Harvey <tharvey@gateworks.com> - 2016-03-31 20:10 +0200
          Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support  via 'ext-reset-output' dt prop Shawn Guo <shawnguo@kernel.org> - 2016-04-01 03:50 +0200

csiph-web