Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1366643 > unrolled thread
| Started by | Gabriele Mazzotta <gabriele.mzt@gmail.com> |
|---|---|
| First post | 2016-03-29 22:20 +0200 |
| Last post | 2016-04-01 11:40 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: multitouch: Synchronize MT frame on reset_resume Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-29 22:20 +0200
Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Benson Leung <bleung@chromium.org> - 2016-03-29 22:40 +0200
Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-03-30 09:50 +0200
Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Jiri Kosina <jikos@kernel.org> - 2016-04-01 11:40 +0200
| From | Gabriele Mazzotta <gabriele.mzt@gmail.com> |
|---|---|
| Date | 2016-03-29 22:20 +0200 |
| Subject | [PATCH] HID: multitouch: Synchronize MT frame on reset_resume |
| Message-ID | <ri8hk-2Tk-35@gated-at.bofh.it> |
input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called at each frame. Do it when releasing the touches, or else we won't get a proper slot number after mt_reset_resume(). Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> --- drivers/hid/hid-multitouch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 25d3c43..c741f5e 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) MT_TOOL_FINGER, false); } + input_mt_sync_frame(input_dev); input_sync(input_dev); } } -- 2.8.0.rc3
[toc] | [next] | [standalone]
| From | Benson Leung <bleung@chromium.org> |
|---|---|
| Date | 2016-03-29 22:40 +0200 |
| Message-ID | <ri8AG-32i-7@gated-at.bofh.it> |
| In reply to | #1366643 |
Hi Gabriele, Thanks for the fix! On Tue, Mar 29, 2016 at 1:10 PM, Gabriele Mazzotta <gabriele.mzt@gmail.com> wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/hid/hid-multitouch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 25d3c43..c741f5e 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) > MT_TOOL_FINGER, > false); > } > + input_mt_sync_frame(input_dev); > input_sync(input_dev); > } > } > -- > 2.8.0.rc3 > -- Benson Leung Senior Software Engineer, Chrom* OS bleung@chromium.org
[toc] | [prev] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-03-30 09:50 +0200 |
| Message-ID | <rij35-27H-21@gated-at.bofh.it> |
| In reply to | #1366643 |
On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Thanks for the fix (I should have spot that earlier :( ) Reviewed-by: Benjamin TIssoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > --- > drivers/hid/hid-multitouch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 25d3c43..c741f5e 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid) > MT_TOOL_FINGER, > false); > } > + input_mt_sync_frame(input_dev); > input_sync(input_dev); > } > } > -- > 2.8.0.rc3 >
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2016-04-01 11:40 +0200 |
| Message-ID | <rj3IB-2lk-3@gated-at.bofh.it> |
| In reply to | #1366643 |
On Tue, 29 Mar 2016, Gabriele Mazzotta wrote: > input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called > at each frame. Do it when releasing the touches, or else we won't get > a proper slot number after mt_reset_resume(). > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> Queued for 4.6. Thanks, -- Jiri Kosina SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web