Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366962

Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

Show all headers | View raw

On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>

Thanks for the fix (I should have spot that earlier :( )

Reviewed-by: Benjamin TIssoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-multitouch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
>  							   MT_TOOL_FINGER,
>  							   false);
>  			}
> +			input_mt_sync_frame(input_dev);
>  			input_sync(input_dev);
>  		}
>  	}
> -- 
> 2.8.0.rc3
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: multitouch: Synchronize MT frame on reset_resume Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2016-03-29 22:20 +0200
  Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Benson Leung <bleung@chromium.org> - 2016-03-29 22:40 +0200
  Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-03-30 09:50 +0200
  Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume Jiri Kosina <jikos@kernel.org> - 2016-04-01 11:40 +0200

csiph-web