Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1365051 > unrolled thread
| Started by | Bhaskar Jupudi <njupudi@ucsc.edu> |
|---|---|
| First post | 2016-03-27 05:50 +0200 |
| Last post | 2016-03-27 13:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers : Remove unnecessary void pointer conversions Bhaskar Jupudi <njupudi@ucsc.edu> - 2016-03-27 05:50 +0200
Re: [PATCH] drivers : Remove unnecessary void pointer conversions Joe Perches <joe@perches.com> - 2016-03-27 07:50 +0200
Re: [PATCH] drivers : Remove unnecessary void pointer conversions Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-27 13:50 +0200
| From | Bhaskar Jupudi <njupudi@ucsc.edu> |
|---|---|
| Date | 2016-03-27 05:50 +0200 |
| Subject | [PATCH] drivers : Remove unnecessary void pointer conversions |
| Message-ID | <rh9S9-2sm-1@gated-at.bofh.it> |
Explicit void pointer conversion is unnecessary
because the conversions to and from a void pointer
are always implicit in 'C'. Changed two instances
of such conversions.
Signed-off-by: Bhaskar Jupudi <njupudi@ucsc.edu>
---
This patch is based on Kernel Janitors To-Do list
drivers/net/ethernet/freescale/fman/fman.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
index 623aa1c..8719f7b 100644
--- a/drivers/net/ethernet/freescale/fman/fman.c
+++ b/drivers/net/ethernet/freescale/fman/fman.c
@@ -2668,7 +2668,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
fm_node = of_node_get(of_dev->dev.of_node);
- u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp);
+ u32_prop = of_get_property(fm_node, "cell-index", &lenp);
if (!u32_prop) {
dev_err(&of_dev->dev, "%s: of_get_property(%s, cell-index) failed\n",
__func__, fm_node->full_name);
@@ -2724,7 +2724,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
/* Rounding to MHz */
fman->dts_params.clk_freq = DIV_ROUND_UP(clk_rate, 1000000);
- u32_prop = (const u32 *)of_get_property(fm_node,
+ u32_prop = of_get_property(fm_node,
"fsl,qman-channel-range",
&lenp);
if (!u32_prop) {
--
2.5.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-27 07:50 +0200 |
| Message-ID | <rhbKi-3I6-1@gated-at.bofh.it> |
| In reply to | #1365051 |
On Sat, 2016-03-26 at 20:42 -0700, Bhaskar Jupudi wrote: > Explicit void pointer conversion is unnecessary > because the conversions to and from a void pointer > are always implicit in 'C'. Changed two instances > of such conversions. Your patch subject is incorrect, this is for fman not all of drivers/ If you do one file, you should do them all. $ git grep -E "\*\s*\)\s*of_get_property" drivers/net/ethernet/freescale/ drivers/net/ethernet/freescale/fman/fman.c: u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp); drivers/net/ethernet/freescale/fman/fman.c: u32_prop = (const u32 *)of_get_property(fm_node, drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node, "cell-index", &lenp); drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node, drivers/net/ethernet/freescale/fman/fman_port.c: u32_prop = (const u32 *)of_get_property(port_node, drivers/net/ethernet/freescale/fman/mac.c: char_prop = (const char *)of_get_property(mac_node, > drivers/net/ethernet/freescale/fman/fman.c | 4 ++--
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-03-27 13:50 +0200 |
| Message-ID | <rhhmF-7Hh-3@gated-at.bofh.it> |
| In reply to | #1365051 |
Hello.
On 3/27/2016 6:42 AM, Bhaskar Jupudi wrote:
> Explicit void pointer conversion is unnecessary
> because the conversions to and from a void pointer
> are always implicit in 'C'. Changed two instances
> of such conversions.
>
>
> Signed-off-by: Bhaskar Jupudi <njupudi@ucsc.edu>
> ---
> This patch is based on Kernel Janitors To-Do list
>
> drivers/net/ethernet/freescale/fman/fman.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
> index 623aa1c..8719f7b 100644
> --- a/drivers/net/ethernet/freescale/fman/fman.c
> +++ b/drivers/net/ethernet/freescale/fman/fman.c
> @@ -2668,7 +2668,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
>
> fm_node = of_node_get(of_dev->dev.of_node);
>
> - u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp);
> + u32_prop = of_get_property(fm_node, "cell-index", &lenp);
This function returns a pointer to big-endian data, no?
> if (!u32_prop) {
> dev_err(&of_dev->dev, "%s: of_get_property(%s, cell-index) failed\n",
> __func__, fm_node->full_name);
> @@ -2724,7 +2724,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
> /* Rounding to MHz */
> fman->dts_params.clk_freq = DIV_ROUND_UP(clk_rate, 1000000);
>
> - u32_prop = (const u32 *)of_get_property(fm_node,
> + u32_prop = of_get_property(fm_node,
Same here...
> "fsl,qman-channel-range",
> &lenp);
Please re-align these continuation lines.
[...]
MBR, Sergei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web