Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365055

Re: [PATCH] drivers : Remove unnecessary void pointer conversions

Show all headers | View raw

On Sat, 2016-03-26 at 20:42 -0700, Bhaskar Jupudi wrote:
> Explicit void pointer conversion is unnecessary
> because the conversions to and from a void pointer
> are always implicit in 'C'. Changed two instances 
> of such conversions.

Your patch subject is incorrect, this is for fman
not all of drivers/

If you do one file, you should do them all.

$ git grep -E "\*\s*\)\s*of_get_property" drivers/net/ethernet/freescale/
drivers/net/ethernet/freescale/fman/fman.c:     u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp);
drivers/net/ethernet/freescale/fman/fman.c:     u32_prop = (const u32 *)of_get_property(fm_node,
drivers/net/ethernet/freescale/fman/fman_port.c:        u32_prop = (const u32 *)of_get_property(port_node, "cell-index", &lenp);
drivers/net/ethernet/freescale/fman/fman_port.c:                u32_prop = (const u32 *)of_get_property(port_node,
drivers/net/ethernet/freescale/fman/fman_port.c:                u32_prop = (const u32 *)of_get_property(port_node,
drivers/net/ethernet/freescale/fman/mac.c:      char_prop = (const char *)of_get_property(mac_node,

>  drivers/net/ethernet/freescale/fman/fman.c | 4 ++--

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers : Remove unnecessary void pointer conversions Bhaskar Jupudi <njupudi@ucsc.edu> - 2016-03-27 05:50 +0200
  Re: [PATCH] drivers : Remove unnecessary void pointer conversions Joe Perches <joe@perches.com> - 2016-03-27 07:50 +0200
  Re: [PATCH] drivers : Remove unnecessary void pointer conversions Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-27 13:50 +0200

csiph-web