Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364863 > unrolled thread

[PATCH 1/8] phy: Fix phy-hi6220-usb dependencies

Started byRichard Weinberger <richard@nod.at>
First post2016-03-25 23:50 +0100
Last post2016-03-30 06:20 +0200
Articles 13 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
      Re: [PATCH 5/8] nvmem: Fix io memory dependencies Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-30 11:00 +0200
    [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
      Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Jonathan Cameron <jic23@kernel.org> - 2016-03-28 10:50 +0200
    [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
      Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Jonathan Cameron <jic23@kernel.org> - 2016-03-28 11:10 +0200
    [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-26 10:10 +0100
      Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger <richard@nod.at> - 2016-03-26 10:30 +0100
    Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 06:20 +0200

#1364863 — [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
Message-ID<rgIIi-6E-3@gated-at.bofh.it>
This driver needs io memory.

Fixes the following Kconfig warning:
warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

And this build error:
drivers/mfd/syscon.c: In function ‘of_syscon_register’:
drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
  base = ioremap(res.start, resource_size(&res));
  ^
drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
  base = ioremap(res.start, resource_size(&res));
       ^
drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(base);

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 26566db..78d2981 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -224,6 +224,7 @@ config PHY_MT65XX_USB3
 
 config PHY_HI6220_USB
 	tristate "hi6220 USB PHY support"
+	depends on HAS_IOMEM
 	depends on (ARCH_HISI && ARM64) || COMPILE_TEST
 	select GENERIC_PHY
 	select MFD_SYSCON
-- 
1.8.4.5

[toc] | [next] | [standalone]

#1364864 — [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies
Message-ID<rgIIi-6E-9@gated-at.bofh.it>
In reply to#1364863
Not all archs have io memory.

Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/phy/phy-bcm-cygnus-pcie.ko] undefined!

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 7856e7d..d209eb1 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -416,6 +416,7 @@ config PHY_BRCMSTB_SATA
 
 config PHY_CYGNUS_PCIE
 	tristate "Broadcom Cygnus PCIe PHY driver"
+	depends on HAS_IOMEM
 	depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
 	select GENERIC_PHY
 	default ARCH_BCM_CYGNUS
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1364865 — [PATCH 7/8] fpga: Fix zynq-fpga dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 7/8] fpga: Fix zynq-fpga dependencies
Message-ID<rgIIi-6E-11@gated-at.bofh.it>
In reply to#1364863
Not all archs have DMA.

Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/fpga/zynq-fpga.ko] undefined!

Cc: Alan Tull <atull@opensource.altera.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf..490ecf0 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -20,6 +20,7 @@ config FPGA_MGR_SOCFPGA
 	  FPGA manager driver support for Altera SOCFPGA.
 
 config FPGA_MGR_ZYNQ_FPGA
+	depends on HAS_DMA
 	tristate "Xilinx Zynq FPGA"
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1364866 — [PATCH 5/8] nvmem: Fix io memory dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 5/8] nvmem: Fix io memory dependencies
Message-ID<rgIIi-6E-13@gated-at.bofh.it>
In reply to#1364863
Not all archs have io memory.

Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_mtk-efuse.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_lpc18xx_eeprom.ko] undefined!

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/nvmem/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index ca52952..3766da3 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -27,6 +27,7 @@ config NVMEM_IMX_OCOTP
 
 config NVMEM_LPC18XX_EEPROM
 	tristate "NXP LPC18XX EEPROM Memory Support"
+	depends on HAS_IOMEM
 	depends on ARCH_LPC18XX || COMPILE_TEST
 	help
 	  Say Y here to include support for NXP LPC18xx EEPROM memory found in
@@ -48,6 +49,7 @@ config NVMEM_MXS_OCOTP
 
 config MTK_EFUSE
 	tristate "Mediatek SoCs EFUSE support"
+	depends on HAS_IOMEM
 	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select REGMAP_MMIO
 	help
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1367020 — Re: [PATCH 5/8] nvmem: Fix io memory dependencies

FromSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Date2016-03-30 11:00 +0200
SubjectRe: [PATCH 5/8] nvmem: Fix io memory dependencies
Message-ID<rik8N-2NM-3@gated-at.bofh.it>
In reply to#1364866
Thanks for the patch,

But there is already a same patch [1] submitted few days back.
I will pick that one.


Thanks,
srini

[1] http://lkml.iu.edu/hypermail/linux/kernel/1603.0/03538.html

On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
>
> Fixes the following build error:
> ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_mtk-efuse.ko] undefined!
> ERROR: "devm_ioremap_resource" [drivers/nvmem/nvmem_lpc18xx_eeprom.ko] undefined!
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>   drivers/nvmem/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index ca52952..3766da3 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -27,6 +27,7 @@ config NVMEM_IMX_OCOTP
>
>   config NVMEM_LPC18XX_EEPROM
>   	tristate "NXP LPC18XX EEPROM Memory Support"
> +	depends on HAS_IOMEM
>   	depends on ARCH_LPC18XX || COMPILE_TEST
>   	help
>   	  Say Y here to include support for NXP LPC18xx EEPROM memory found in
> @@ -48,6 +49,7 @@ config NVMEM_MXS_OCOTP
>
>   config MTK_EFUSE
>   	tristate "Mediatek SoCs EFUSE support"
> +	depends on HAS_IOMEM
>   	depends on ARCH_MEDIATEK || COMPILE_TEST
>   	select REGMAP_MMIO
>   	help
>

[toc] | [prev] | [next] | [standalone]

#1364867 — [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies
Message-ID<rgIIi-6E-15@gated-at.bofh.it>
In reply to#1364863
Not all archs have io memory.

Fixes the following build error:
ERROR: "devm_ioremap_resource" [drivers/iio/adc/at91-sama5d2_adc.ko] undefined!

Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
Fixes: b9cd7a25 ("MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index af4aea7..31fa2e7 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -133,6 +133,7 @@ config AT91_ADC
 
 config AT91_SAMA5D2_ADC
 	tristate "Atmel AT91 SAMA5D2 ADC"
+	depends on HAS_IOMEM
 	depends on ARCH_AT91 || COMPILE_TEST
 	help
 	  Say yes here to build support for Atmel SAMA5D2 ADC which is
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1365391 — Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies

FromJonathan Cameron <jic23@kernel.org>
Date2016-03-28 10:50 +0200
SubjectRe: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies
Message-ID<rhB22-4pt-17@gated-at.bofh.it>
In reply to#1364867
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> 
> Fixes the following build error:
> ERROR: "devm_ioremap_resource" [drivers/iio/adc/at91-sama5d2_adc.ko] undefined!
> 
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: b9cd7a25 ("MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver")
> Signed-off-by: Richard Weinberger <richard@nod.at>
Hi Richard,

I already have a patch queued up covering this, it just hit at exactly the wrong
moment compared to the merge window so hasn't made it upstream yet.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..31fa2e7 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -133,6 +133,7 @@ config AT91_ADC
>  
>  config AT91_SAMA5D2_ADC
>  	tristate "Atmel AT91 SAMA5D2 ADC"
> +	depends on HAS_IOMEM
>  	depends on ARCH_AT91 || COMPILE_TEST
>  	help
>  	  Say yes here to build support for Atmel SAMA5D2 ADC which is
>

[toc] | [prev] | [next] | [standalone]

#1364868 — [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies
Message-ID<rgIIi-6E-17@gated-at.bofh.it>
In reply to#1364863
Not all archs have io memory.
Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
depend directly on it.

Fixes the following kconfig warning:
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
And this build error:
ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!

Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
index a7f557a..847455a 100644
--- a/drivers/iio/imu/inv_mpu6050/Kconfig
+++ b/drivers/iio/imu/inv_mpu6050/Kconfig
@@ -9,9 +9,8 @@ config INV_MPU6050_IIO
 
 config INV_MPU6050_I2C
 	tristate "Invensense MPU6050 devices (I2C)"
-	depends on I2C
+	depends on I2C_MUX
 	select INV_MPU6050_IIO
-	select I2C_MUX
 	select REGMAP_I2C
 	help
 	  This driver supports the Invensense MPU6050 devices.
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1365394 — Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies

FromJonathan Cameron <jic23@kernel.org>
Date2016-03-28 11:10 +0200
SubjectRe: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies
Message-ID<rhBlo-4N8-3@gated-at.bofh.it>
In reply to#1364868
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
> depend directly on it.
> 
> Fixes the following kconfig warning:
> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
> And this build error:
> ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> 
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Applied to the fixes-togreg-post-rc1 branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
> index a7f557a..847455a 100644
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> @@ -9,9 +9,8 @@ config INV_MPU6050_IIO
>  
>  config INV_MPU6050_I2C
>  	tristate "Invensense MPU6050 devices (I2C)"
> -	depends on I2C
> +	depends on I2C_MUX
>  	select INV_MPU6050_IIO
> -	select I2C_MUX
>  	select REGMAP_I2C
>  	help
>  	  This driver supports the Invensense MPU6050 devices.
>

[toc] | [prev] | [next] | [standalone]

#1364869 — [PATCH 2/8] mailbox: Fix rockchip dependencies

FromRichard Weinberger <richard@nod.at>
Date2016-03-25 23:50 +0100
Subject[PATCH 2/8] mailbox: Fix rockchip dependencies
Message-ID<rgIIj-6E-23@gated-at.bofh.it>
In reply to#1364863
This driver needs io memory but not all archs offer it.

Fixes the following build error:
drivers/built-in.o: In function `rockchip_mbox_probe':
rockchip-mailbox.c:(.text+0x4b19c): undefined reference to `devm_ioremap_resource'

Cc: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/mailbox/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 5305923..5ee207c 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -45,6 +45,7 @@ config OMAP_MBOX_KFIFO_SIZE
 
 config ROCKCHIP_MBOX
 	bool "Rockchip Soc Intergrated Mailbox Support"
+	depends on HAS_IOMEM
 	depends on ARCH_ROCKCHIP || COMPILE_TEST
 	help
 	  This driver provides support for inter-processor communication
-- 
1.8.4.5

[toc] | [prev] | [next] | [standalone]

#1364928

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-03-26 10:10 +0100
Message-ID<rgSoh-78I-1@gated-at.bofh.it>
In reply to#1364863
Hi Richard,

On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>   base = ioremap(res.start, resource_size(&res));
>   ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>   base = ioremap(res.start, resource_size(&res));
>        ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")

I don't think that commit is the root cause ;-)
Before there were no dependencies at all...

Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb")

> Signed-off-by: Richard Weinberger <richard@nod.at>

With the above fixed:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1364931

FromRichard Weinberger <richard@nod.at>
Date2016-03-26 10:30 +0100
Message-ID<rgSHD-7gF-1@gated-at.bofh.it>
In reply to#1364928
Am 26.03.2016 um 10:05 schrieb Geert Uytterhoeven:
> Hi Richard,
> 
> On Fri, Mar 25, 2016 at 11:40 PM, Richard Weinberger <richard@nod.at> wrote:
>> This driver needs io memory.
>>
>> Fixes the following Kconfig warning:
>> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>>
>> And this build error:
>> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
>> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>>   base = ioremap(res.start, resource_size(&res));
>>   ^
>> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>>   base = ioremap(res.start, resource_size(&res));
>>        ^
>> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>>   iounmap(base);
>>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
> 
> I don't think that commit is the root cause ;-)
> Before there were no dependencies at all...

Fair point. :-)

> Fixes: 30e9a0b2147c8405 ("phy: add phy-hi6220-usb")
> 
>> Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> With the above fixed:
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks,
//richard

[toc] | [prev] | [next] | [standalone]

#1366885

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-30 06:20 +0200
Message-ID<rifLP-8p2-1@gated-at.bofh.it>
In reply to#1364863
On Sat, Mar 26, 2016 at 7:40 AM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>   base = ioremap(res.start, resource_size(&res));
>   ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>   base = ioremap(res.start, resource_size(&res));
>        ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
> Signed-off-by: Richard Weinberger <richard@nod.at>

Waiting with this from 3rd March...
https://www.spinics.net/lists/linux-usb/msg137114.html
(and resent on 15th https://lkml.org/lkml/2016/3/16/408)
...but indeed recent Rob's work is a better solution.

BR,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web