Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies
Date	2016-03-30 06:20 +0200
Message-ID	<rifLP-8p2-1@gated-at.bofh.it> (permalink)
References	<rgIIi-6E-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 26, 2016 at 7:40 AM, Richard Weinberger <richard@nod.at> wrote:
> This driver needs io memory.
>
> Fixes the following Kconfig warning:
> warning: (ST_IRQCHIP && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>
> And this build error:
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/mfd/syscon.c:67:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
>   base = ioremap(res.start, resource_size(&res));
>   ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>   base = ioremap(res.start, resource_size(&res));
>        ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(base);
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d896910f3 ("phy: Restrict phy-hi6220-usb to HiSilicon arm64")
> Signed-off-by: Richard Weinberger <richard@nod.at>

Waiting with this from 3rd March...
https://www.spinics.net/lists/linux-usb/msg137114.html
(and resent on 15th https://lkml.org/lkml/2016/3/16/408)
...but indeed recent Rob's work is a better solution.

BR,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
  [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
  [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
  [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    Re: [PATCH 5/8] nvmem: Fix io memory dependencies Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-30 11:00 +0200
  [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    Re: [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Jonathan Cameron <jic23@kernel.org> - 2016-03-28 10:50 +0200
  [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
    Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Jonathan Cameron <jic23@kernel.org> - 2016-03-28 11:10 +0200
  [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger <richard@nod.at> - 2016-03-25 23:50 +0100
  Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-26 10:10 +0100
    Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger <richard@nod.at> - 2016-03-26 10:30 +0100
  Re: [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 06:20 +0200

csiph-web