Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360540 > unrolled thread

[PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

Started byTomeu Vizoso <tomeu.vizoso@collabora.com>
First post2016-03-18 12:30 +0100
Last post2016-03-21 09:40 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-03-18 12:30 +0100
    Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Andreas Färber <afaerber@suse.de> - 2016-03-18 22:40 +0100
      Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-03-21 09:30 +0100
        Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Michael Trimarchi <michael@amarulasolutions.com> - 2016-03-21 09:40 +0100

#1360540 — [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

FromTomeu Vizoso <tomeu.vizoso@collabora.com>
Date2016-03-18 12:30 +0100
Subject[PATCH] ARM: dts: rockchip: Add mdio node to ethernet node
Message-ID<re0Ln-4Z2-5@gated-at.bofh.it>
So the dwmac device manages to probe again.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
---
 arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1ece66f3e162..4ba7ddecb478 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -101,6 +101,14 @@
 	snps,reset-delays-us = <0 10000 30000>;
 	rx_delay = <0x10>;
 	tx_delay = <0x30>;
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		ethphy1: ethernet-phy@1 {
+			reg = <1>;
+		};
+	};
 };
 
 &i2c0 {
-- 
2.5.0

[toc] | [next] | [standalone]

#1360943

FromAndreas Färber <afaerber@suse.de>
Date2016-03-18 22:40 +0100
Message-ID<reahH-Ok-9@gated-at.bofh.it>
In reply to#1360540
Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]

#1361602

FromTomeu Vizoso <tomeu.vizoso@collabora.com>
Date2016-03-21 09:30 +0100
Message-ID<rf3nQ-2Wt-25@gated-at.bofh.it>
In reply to#1360943
On 18 March 2016 at 22:34, Andreas Färber <afaerber@suse.de> wrote:
> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>> So the dwmac device manages to probe again.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>> ---
>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> index 1ece66f3e162..4ba7ddecb478 100644
>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> @@ -101,6 +101,14 @@
>>       snps,reset-delays-us = <0 10000 30000>;
>>       rx_delay = <0x10>;
>>       tx_delay = <0x30>;
>> +     mdio0 {
>> +             #address-cells = <1>;
>> +             #size-cells = <0>;
>> +             compatible = "snps,dwmac-mdio";
>> +             ethphy1: ethernet-phy@1 {
>> +                     reg = <1>;
>> +             };
>> +     };
>
> This is a) ugly for lack of white lines in between, b) unnecessary since
> this is being fixed in the stmmac driver where it will benefit more than
> just this one SoM.

So is this redundant information, or just not necessary with the
present kernel driver because of some assumption in its current
implementation?

Thanks,

Tomeu

> Regards,
> Andreas
>
>>  };
>>
>>  &i2c0 {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]

#1361604

FromMichael Trimarchi <michael@amarulasolutions.com>
Date2016-03-21 09:40 +0100
Message-ID<rf3xv-2ZN-1@gated-at.bofh.it>
In reply to#1361602
Hi

On Mon, Mar 21, 2016 at 9:23 AM, Tomeu Vizoso
<tomeu.vizoso@collabora.com> wrote:
> On 18 March 2016 at 22:34, Andreas Färber <afaerber@suse.de> wrote:
>> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>>> So the dwmac device manages to probe again.
>>>
>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> ---
>>>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> index 1ece66f3e162..4ba7ddecb478 100644
>>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> @@ -101,6 +101,14 @@
>>>       snps,reset-delays-us = <0 10000 30000>;
>>>       rx_delay = <0x10>;
>>>       tx_delay = <0x30>;
>>> +     mdio0 {
>>> +             #address-cells = <1>;
>>> +             #size-cells = <0>;
>>> +             compatible = "snps,dwmac-mdio";
>>> +             ethphy1: ethernet-phy@1 {
>>> +                     reg = <1>;
>>> +             };
>>> +     };
>>
>> This is a) ugly for lack of white lines in between, b) unnecessary since
>> this is being fixed in the stmmac driver where it will benefit more than
>> just this one SoM.
>
> So is this redundant information, or just not necessary with the
> present kernel driver because of some assumption in its current
> implementation?
>

I have the same fix on my firefly tree. Look likes correct and describe the
connection

Michael

> Thanks,
>
> Tomeu
>
>> Regards,
>> Andreas
>>
>>>  };
>>>
>>>  &i2c0 {
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web