Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360943

Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

Show all headers | View raw

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-03-18 12:30 +0100
  Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Andreas Färber <afaerber@suse.de> - 2016-03-18 22:40 +0100
    Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-03-21 09:30 +0100
      Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Michael Trimarchi <michael@amarulasolutions.com> - 2016-03-21 09:40 +0100

csiph-web