Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1361303 > unrolled thread

[PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

Started byParth Sane <laerdevstudios@gmail.com>
First post2016-03-20 15:40 +0100
Last post2016-03-20 17:50 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 15:40 +0100
    Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Joe Perches <joe@perches.com> - 2016-03-20 16:50 +0100
      Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 17:00 +0100
        Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment Parth Sane <laerdevstudios@gmail.com> - 2016-03-20 17:50 +0100

#1361303 — [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

FromParth Sane <laerdevstudios@gmail.com>
Date2016-03-20 15:40 +0100
Subject[PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment
Message-ID<reMGm-8a8-9@gated-at.bofh.it>
Fixed multiple parenthesis alignment warnings.
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
 drivers/staging/rtl8712/hal_init.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
index 225ef37..afa7fe78 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 						       0x0000ffff);
 			memcpy(ppayload, ptr, dump_imem_sz);
 			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-				  dump_imem_sz + TXDESC_SIZE,
+					dump_imem_sz + TXDESC_SIZE,
 				  (u8 *)ptx_desc);
 			ptr += dump_imem_sz;
 			imem_sz -= dump_imem_sz;
@@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 						       0x0000ffff);
 			memcpy(ppayload, ptr, dump_emem_sz);
 			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-				  dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+					dump_emem_sz + TXDESC_SIZE,
+					(u8 *)ptx_desc);
 			ptr += dump_emem_sz;
 			emem_sz -= dump_emem_sz;
 		} while (emem_sz > 0);
@@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 		ptx_desc->txdw0 |= cpu_to_le32(BIT(28));
 		memcpy(ppayload, &fwhdr.fwpriv, fwhdr.fw_priv_sz);
 		r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-			  fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+				fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
 
 		/* polling dmem code done */
 		i = 100;
-- 
1.9.1

[toc] | [next] | [standalone]

#1361306

FromJoe Perches <joe@perches.com>
Date2016-03-20 16:50 +0100
Message-ID<reNM6-pp-5@gated-at.bofh.it>
In reply to#1361303
On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote:
> Fixed multiple parenthesis alignment warnings.
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

Please always add a blank line after your changelog and
before your "Signed-off-by:" line

> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
[]
> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
>  						       0x0000ffff);
>  			memcpy(ppayload, ptr, dump_imem_sz);
>  			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
> -				  dump_imem_sz + TXDESC_SIZE,
> +					dump_imem_sz + TXDESC_SIZE,
>  				  (u8 *)ptx_desc);

Please align all lines of multi-line statements.

checkpatch is a stupid little script.
You have to make sure your own patches are sensible.

There are several things you should read and
understand in the Documentation directory.

	Documentation/CodingStyle
	Documentation/SubmittingPatches
	Documentation/SubmitChecklist

Fixing checkpatch messages is sometimes a decent
way to understand this process, but the patches
that can be generated fixing these messages tend
to have low overall value.

After doing a few of these, please move on to
some part of the kernel that interests you and
submit new code or start to fix actual defects.

Maybe if you are interested in wireless drivers,
buy a NIC that isn't supported by the mac80211
drivers and adapt the existing staging driver for
that variant.

Code, test, validate, submit, repeat...

[toc] | [prev] | [next] | [standalone]

#1361314

FromParth Sane <laerdevstudios@gmail.com>
Date2016-03-20 17:00 +0100
Message-ID<reNVL-sU-7@gated-at.bofh.it>
In reply to#1361306

[Multipart message — attachments visible in raw view] — view raw

> On 20-Mar-2016, at 9:18 PM, Joe Perches <joe@perches.com> wrote:
> 
> On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote:
>> Fixed multiple parenthesis alignment warnings.
>> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> Please always add a blank line after your changelog and
> before your "Signed-off-by:" line
> 
>> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> []
>> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
>>  						       0x0000ffff);
>>  			memcpy(ppayload, ptr, dump_imem_sz);
>>  			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
>> -				  dump_imem_sz + TXDESC_SIZE,
>> +					dump_imem_sz + TXDESC_SIZE,
>>  				  (u8 *)ptx_desc);
> 
> Please align all lines of multi-line statements.
> 
> checkpatch is a stupid little script.
> You have to make sure your own patches are sensible.
> 
> There are several things you should read and
> understand in the Documentation directory.
> 
> 	Documentation/CodingStyle
> 	Documentation/SubmittingPatches
> 	Documentation/SubmitChecklist
> 
> Fixing checkpatch messages is sometimes a decent
> way to understand this process, but the patches
> that can be generated fixing these messages tend
> to have low overall value.
> 
> After doing a few of these, please move on to
> some part of the kernel that interests you and
> submit new code or start to fix actual defects.
> 
> Maybe if you are interested in wireless drivers,
> buy a NIC that isn't supported by the mac80211
> drivers and adapt the existing staging driver for
> that variant.
> 
> Code, test, validate, submit, repeat...
> 
Hi,
I’m first trying my hands at easy stuff before I actually move on to more difficult stuff. I will surely look in that direction. Thanks for your valuable inputs.
Regards,
Parth Sane

[toc] | [prev] | [next] | [standalone]

#1361323

FromParth Sane <laerdevstudios@gmail.com>
Date2016-03-20 17:50 +0100
Message-ID<reOIa-12F-7@gated-at.bofh.it>
In reply to#1361314

[Multipart message — attachments visible in raw view] — view raw

> On 20-Mar-2016, at 10:03 PM, Roger H Newell <newell.roger@gmail.com> wrote:
> 
> 
> On Mar 20, 2016 1:21 PM, "Parth Sane" <laerdevstudios@gmail.com> wrote:
> >
> >
> > > On 20-Mar-2016, at 9:18 PM, Joe Perches <joe@perches.com> wrote:
> > >
> > > On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote:
> > >> Fixed multiple parenthesis alignment warnings.
> > >> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> > >
> > > Please always add a blank line after your changelog and
> > > before your "Signed-off-by:" line
> > >
> > >> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> > > []
> > >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
> > >>                                                     0x0000ffff);
> > >>                      memcpy(ppayload, ptr, dump_imem_sz);
> > >>                      r8712_write_mem(padapter, RTL8712_DMA_VOQ,
> > >> -                              dump_imem_sz + TXDESC_SIZE,
> > >> +                                    dump_imem_sz + TXDESC_SIZE,
> > >>                                (u8 *)ptx_desc);
> > >
> > > Please align all lines of multi-line statements.
> > >
> > > checkpatch is a stupid little script.
> > > You have to make sure your own patches are sensible.
> > >
> > > There are several things you should read and
> > > understand in the Documentation directory.
> > >
> > >       Documentation/CodingStyle
> > >       Documentation/SubmittingPatches
> > >       Documentation/SubmitChecklist
> > >
> > > Fixing checkpatch messages is sometimes a decent
> > > way to understand this process, but the patches
> > > that can be generated fixing these messages tend
> > > to have low overall value.
> > >
> > > After doing a few of these, please move on to
> > > some part of the kernel that interests you and
> > > submit new code or start to fix actual defects.
> > >
> > > Maybe if you are interested in wireless drivers,
> > > buy a NIC that isn't supported by the mac80211
> > > drivers and adapt the existing staging driver for
> > > that variant.
> > >
> > > Code, test, validate, submit, repeat...
> > >
> > Hi,
> > I’m first trying my hands at easy stuff before I actually move on to more difficult stuff. I will surely look in that direction. Thanks for your valuable inputs.
> > Regards,
> > Parth Sane
> >
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >
> 
> www.kernelnewbies.org is an excellent resource for getting started. Check out the first patch tutorial, it walks you through all the basics of creating and sending a properly formated patch. You're better off learning to do it right the first  time, if its not right the patch simply won't be accepted and you'll have to redo it anyway. Take some time to go through the tutorial I  mentioned. Good luck
> 
> Roger H. Newell
> 
Hi Roger,
Thanks for your comments. I’ve correctly submitted a patchset for the multiple FSF notices, maybe you can comment if its any good?. I’m through the rough patch and now understand the process now quite fairly.
I did checkout kernelnewbies.org before I submitted the patch, but alas I needed some practical XP.
Regards,
Parth Sane

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web