Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360954 > unrolled thread

Re: [GIT PULL] USB driver patches for 4.6-rc1

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-18 22:50 +0100
    Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-18 23:00 +0100
      Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-18 23:20 +0100
        Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-18 23:30 +0100
      Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:00 +0100
        Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-19 00:00 +0100
          Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:20 +0100
            Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-19 00:20 +0100
        Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:10 +0100
          Re: [GIT PULL] USB driver patches for 4.6-rc1 Peter Chen <hzpeterchen@gmail.com> - 2016-03-20 12:40 +0100

#1360954 — Re: [GIT PULL] USB driver patches for 4.6-rc1

On Wed, Mar 16, 2016 at 5:09 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> USB patches for 4.6-rc1
>
> Here is the big USB patchset for 4.6-rc1.

Something in this - or possibly the tty pull, but that doesn't sound
very likely - has killed my USB keyboard on my desktop.

I'm bisecting right now. Expect a likely revert.

                Linus

[toc] | [next] | [standalone]

#1360958

On Fri, Mar 18, 2016 at 2:43 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Something in this - or possibly the tty pull, but that doesn't sound
> very likely - has killed my USB keyboard on my desktop.

Yeah, the bisect is now solidly in the usb part.

The machine has

00:14.0 USB controller: Intel Corporation Sunrise Point-H USB 3.0 xHCI
Controller (rev 31)
03:00.0 USB controller: ASMedia Technology Inc. ASM1142 USB 3.1 Host Controller

and the keyboard and mouse are on

/:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M

which seems to be that ASMedia 3.1 controller.

In case that gives anybody a clue while I continue bisecting.

                  Linus

[toc] | [prev] | [next] | [standalone]

#1360963

On Fri, Mar 18, 2016 at 02:58:27PM -0700, Linus Torvalds wrote:
> On Fri, Mar 18, 2016 at 2:43 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Something in this - or possibly the tty pull, but that doesn't sound
> > very likely - has killed my USB keyboard on my desktop.
> 
> Yeah, the bisect is now solidly in the usb part.
> 
> The machine has
> 
> 00:14.0 USB controller: Intel Corporation Sunrise Point-H USB 3.0 xHCI
> Controller (rev 31)
> 03:00.0 USB controller: ASMedia Technology Inc. ASM1142 USB 3.1 Host Controller
> 
> and the keyboard and mouse are on
> 
> /:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M
> 
> which seems to be that ASMedia 3.1 controller.
> 
> In case that gives anybody a clue while I continue bisecting.

Hm, your tree as of this morning works just fine for me right now (am
typing this from a USB keyboard), but I have an older host controller:
	00:14.0 USB controller: Intel Corporation 8 Series/C220 Series Chipset Family USB xHCI (rev 04)


I do see an oops in the snd_usb_audio driver that I didn't notice
before:


[  +0.002298] input: Schiit Audio USB Modi Device as /devices/pci0000:00/0000:00:14.0/usb2/2-10/2-10.1/2-10.1:1.2/0003:0D8C:1319.0001/input/input17
[  +0.000056] hid-generic 0003:0D8C:1319.0001: input,hidraw0: USB HID v1.00 Device [Schiit Audio USB Modi Device] on usb-0000:00:14.0-10.1/input2
[  +0.008749] BUG: unable to handle kernel NULL pointer dereference at 0000000000000014
[  +0.001151] IP: [<ffffffffc0e79921>] usb_audio_probe+0x1e1/0x8f0 [snd_usb_audio]
[  +0.001142] PGD 0 
[  +0.001114] Oops: 0000 [#1] PREEMPT SMP 
[  +0.001115] Modules linked in: snd_usb_audio(+) hid_generic snd_usbmidi_lib usbhid snd_rawmidi snd_seq_device hid media arc4 fuse btusb btrtl btbcm btintel bluetooth rt2800usb rt2x00usb rt2800lib rt2x00lib mac80211 crc_ccitt cfg80211 rfkill nls_cp437 vfat fat iTCO_wdt iTCO_vendor_support mxm_wmi x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crct10dif_common crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd psmouse serio_raw pcspkr firewire_ohci firewire_core crc_itu_t xhci_pci ehci_pci xhci_hcd ehci_hcd mei_me usbcore mei lpc_ich mfd_core usb_common wmi evdev ip_tables x_tables
[  +0.004079] CPU: 4 PID: 615 Comm: systemd-udevd Not tainted 4.6.0-rc1+ #103
[  +0.001382] Hardware name:                  /        , BIOS KLZ8711D.86A.0457.2015.0713.1319 07/13/2015
[  +0.001387] task: ffff880098ec0e00 ti: ffff880251920000 task.ti: ffff880251920000
[  +0.001417] RIP: 0010:[<ffffffffc0e79921>]  [<ffffffffc0e79921>] usb_audio_probe+0x1e1/0x8f0 [snd_usb_audio]
[  +0.001414] RSP: 0018:ffff880251923af0  EFLAGS: 00010246
[  +0.001409] RAX: 0000000000000000 RBX: ffff88024d602000 RCX: 0000000000000000
[  +0.001404] RDX: ffff880254e0b340 RSI: ffff8802559b99f8 RDI: ffffffff82181030
[  +0.001413] RBP: ffff880251923b50 R08: 0000000000019d00 R09: ffffffff81385837
[  +0.001431] R10: ffffea0009461200 R11: ffff880253b3fe72 R12: 0000000000000000
[  +0.001411] R13: 0000000000000000 R14: 0000000000000001 R15: ffff88025338c212
[  +0.001436] FS:  00007f7a8db567c0(0000) GS:ffff88025fb00000(0000) knlGS:0000000000000000
[  +0.001431] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  +0.001445] CR2: 0000000000000014 CR3: 0000000251854000 CR4: 00000000001406e0
[  +0.001451] Stack:
[  +0.001433]  ffff880253302e88 ffff88024d602054 ffff88009879d000 ffff880253302e88
[  +0.001480]  ffff880255f7e000 386430425355d030 ff00393133313a63 ffff8800984f4098
[  +0.001466]  ffff8800984f4000 ffffffffc0e95728 ffff88009879d030 ffffffffc0e955a0
[  +0.001497] Call Trace:
[  +0.001295]  [<ffffffffc0067cfd>] usb_probe_interface+0x1bd/0x300 [usbcore]
[  +0.001427]  [<ffffffff815987e9>] driver_probe_device+0x249/0x450
[  +0.001400]  [<ffffffff81598a74>] __driver_attach+0x84/0x90
[  +0.001398]  [<ffffffff815989f0>] ? driver_probe_device+0x450/0x450
[  +0.001417]  [<ffffffff815963e4>] bus_for_each_dev+0x64/0xa0
[  +0.001369]  [<ffffffff81597ede>] driver_attach+0x1e/0x20
[  +0.001396]  [<ffffffff815979ab>] bus_add_driver+0x1eb/0x280
[  +0.001365]  [<ffffffff81599390>] driver_register+0x60/0xe0
[  +0.001369]  [<ffffffffc0066834>] usb_register_driver+0x84/0x140 [usbcore]
[  +0.001422]  [<ffffffffc0e9d000>] ? 0xffffffffc0e9d000
[  +0.001370]  [<ffffffffc0e9d01e>] usb_audio_driver_init+0x1e/0x20 [snd_usb_audio]
[  +0.001472]  [<ffffffff8100211b>] do_one_initcall+0xab/0x1d0
[  +0.001547]  [<ffffffff8115e732>] do_init_module+0x5f/0x1cd
[  +0.001469]  [<ffffffff810f9ec8>] load_module+0x1368/0x1510
[  +0.001542]  [<ffffffff810f75d0>] ? symbol_put_addr+0x50/0x50
[  +0.001468]  [<ffffffff810fa2a8>] SyS_finit_module+0xc8/0xf0
[  +0.001451]  [<ffffffff81003c6e>] do_syscall_64+0x5e/0xc0
[  +0.001538]  [<ffffffff817fb425>] entry_SYSCALL64_slow_path+0x25/0x25
[  +0.001397] Code: f8 01 00 44 89 e6 48 89 df e8 dc 73 00 00 85 c0 89 c1 0f 88 99 00 00 00 48 8b 7b 10 e8 c9 0b 80 c0 85 c0 89 c1 0f 88 86 00 00 00 <41> 80 7d 14 00 0f 85 90 04 00 00 48 63 03 48 89 1c c5 40 90 e9 
[  +0.001513] RIP  [<ffffffffc0e79921>] usb_audio_probe+0x1e1/0x8f0 [snd_usb_audio]
[  +0.001468]  RSP <ffff880251923af0>
[  +0.001576] CR2: 0000000000000014
[  +0.010610] ---[ end trace c9cdd61401b8f1d9 ]---

But my keyboard still works :)

The results of bisection will be interesting to see...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1360969

On Fri, Mar 18, 2016 at 03:12:15PM -0700, Greg KH wrote:
> On Fri, Mar 18, 2016 at 02:58:27PM -0700, Linus Torvalds wrote:
> > On Fri, Mar 18, 2016 at 2:43 PM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > Something in this - or possibly the tty pull, but that doesn't sound
> > > very likely - has killed my USB keyboard on my desktop.
> > 
> > Yeah, the bisect is now solidly in the usb part.
> > 
> > The machine has
> > 
> > 00:14.0 USB controller: Intel Corporation Sunrise Point-H USB 3.0 xHCI
> > Controller (rev 31)
> > 03:00.0 USB controller: ASMedia Technology Inc. ASM1142 USB 3.1 Host Controller
> > 
> > and the keyboard and mouse are on
> > 
> > /:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M
> > 
> > which seems to be that ASMedia 3.1 controller.
> > 
> > In case that gives anybody a clue while I continue bisecting.
> 
> Hm, your tree as of this morning works just fine for me right now (am
> typing this from a USB keyboard), but I have an older host controller:
> 	00:14.0 USB controller: Intel Corporation 8 Series/C220 Series Chipset Family USB xHCI (rev 04)
> 
> 
> I do see an oops in the snd_usb_audio driver that I didn't notice
> before:

Ok, I pulled your latest tree and I get the same results, sound driver
crashes, but keyboard works fine.  I'll go poke the sound developers
about it.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1360982

On Fri, Mar 18, 2016 at 2:58 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Yeah, the bisect is now solidly in the usb part.

The commit that ends up being marked bad is odd, but there it is:
69bec7259853 "USB: core: let USB device know device node".

Very odd, but I tested multiple times: I'm typing this on
d883f52e1f6d, and everything is fine. On 69bec7259853, I can't type.

Note that when I say "I can't type", it's the early boot disk
encryption password.  And maybe there's an oops there, but I can't see
it, and I can't log it.

I don't even have CONFIG_OF enabled, so I don't see what difference
that patch would make. But it makes some difference.

I'll double-check by reverting it on top of current git (it does seem
to at least revert cleanly), I haven't done that yet. But adding the
people involved in that commit to the discussion to see if anybody
sees anything.

              Linus

[toc] | [prev] | [next] | [standalone]

#1360985

[Multipart message — attachments visible in raw view] — view raw

On Fri, Mar 18, 2016 at 03:51:34PM -0700, Linus Torvalds wrote:
> On Fri, Mar 18, 2016 at 2:58 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Yeah, the bisect is now solidly in the usb part.
> 
> The commit that ends up being marked bad is odd, but there it is:
> 69bec7259853 "USB: core: let USB device know device node".
> 
> Very odd, but I tested multiple times: I'm typing this on
> d883f52e1f6d, and everything is fine. On 69bec7259853, I can't type.
> 
> Note that when I say "I can't type", it's the early boot disk
> encryption password.  And maybe there's an oops there, but I can't see
> it, and I can't log it.
> 
> I don't even have CONFIG_OF enabled, so I don't see what difference
> that patch would make. But it makes some difference.
> 
> I'll double-check by reverting it on top of current git (it does seem
> to at least revert cleanly), I haven't done that yet. But adding the
> people involved in that commit to the discussion to see if anybody
> sees anything.

Yes, people did report issues with that yesterday, and I queued up a
patch for it, it's attached below, but I didn't think it would cause any
issues with non-OF systems either.  I wanted to give it a few days
testing in linux-next before sending it to you, but can do so now if you
want.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1360992

On Fri, Mar 18, 2016 at 3:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> Yes, people did report issues with that yesterday, and I queued up a
> patch for it, it's attached below, but I didn't think it would cause any
> issues with non-OF systems either.  I wanted to give it a few days
> testing in linux-next before sending it to you, but can do so now if you
> want.

Ok, that fixes it for me. Yeah, I'll need this in order to continue
merging, I don't merge more stuff on top of known-bad kernels.

I can apply the patch directly (I did it on that machine for testing),
or take a pull request. Just let me know.

                      Linus

[toc] | [prev] | [next] | [standalone]

#1360993

On Fri, Mar 18, 2016 at 04:09:50PM -0700, Linus Torvalds wrote:
> On Fri, Mar 18, 2016 at 3:58 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Yes, people did report issues with that yesterday, and I queued up a
> > patch for it, it's attached below, but I didn't think it would cause any
> > issues with non-OF systems either.  I wanted to give it a few days
> > testing in linux-next before sending it to you, but can do so now if you
> > want.
> 
> Ok, that fixes it for me. Yeah, I'll need this in order to continue
> merging, I don't merge more stuff on top of known-bad kernels.
> 
> I can apply the patch directly (I did it on that machine for testing),
> or take a pull request. Just let me know.

Here's the pull request, it also includes some security fixes that have
been reported publicly, and a crash for the UAS driver that some people
have hit already.

------------


The following changes since commit 48d10bda1f2c69980601a61194015bb0790fb7ab:

  Merge tag 'usb-4.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb (2016-03-17 14:24:26 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.6-rc1

for you to fetch changes up to 55ff8cfbc4e12a7d2187df523938cc671fbebdd1:

  USB: uas: Reduce can_queue to MAX_CMNDS (2016-03-18 09:19:02 -0700)

----------------------------------------------------------------
USB fixes for 4.6-rc1

Here is a USB fix for the reported issue with 69bec7259853 "USB: core:
let USB device know device node" as well as some other issues that have
been reported so far with this merge.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

----------------------------------------------------------------
Hans de Goede (1):
      USB: uas: Reduce can_queue to MAX_CMNDS

Josh Boyer (1):
      USB: iowarrior: fix oops with malicious USB descriptors

Nicolai Stange (1):
      usb/core: usb_alloc_dev(): fix setting of ->portnum

Oliver Neukum (2):
      USB: usb_driver_claim_interface: add sanity checking
      USB: cdc-acm: more sanity checking

 drivers/usb/class/cdc-acm.c  | 3 +++
 drivers/usb/core/driver.c    | 6 +++++-
 drivers/usb/core/usb.c       | 5 +++--
 drivers/usb/misc/iowarrior.c | 6 ++++++
 drivers/usb/storage/uas.c    | 2 +-
 5 files changed, 18 insertions(+), 4 deletions(-)

[toc] | [prev] | [next] | [standalone]

#1360988

On Fri, Mar 18, 2016 at 3:51 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The commit that ends up being marked bad is odd, but there it is:
> 69bec7259853 "USB: core: let USB device know device node".

Confirmed. Not only did it bisect to that, reverting it on top of the
current kernel fixes my machine.

So that commit is somehow buggy. I don't see what it does that would
break even with OF disabled, but something does.

I'll just revert it. The way it is done seems bogus anyway.  It looks
at of_node when OF is disabled, but generally that isn't even
initialized as far as I can tell, and we have things like
dev_of_node() helpers to make sure you don't do that.

               Linus

[toc] | [prev] | [next] | [standalone]

#1361247

On Fri, Mar 18, 2016 at 04:01:51PM -0700, Linus Torvalds wrote:
> On Fri, Mar 18, 2016 at 3:51 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > The commit that ends up being marked bad is odd, but there it is:
> > 69bec7259853 "USB: core: let USB device know device node".
> 
> Confirmed. Not only did it bisect to that, reverting it on top of the
> current kernel fixes my machine.
> 
> So that commit is somehow buggy. I don't see what it does that would
> break even with OF disabled, but something does.
> 
> I'll just revert it. The way it is done seems bogus anyway.  It looks
> at of_node when OF is disabled, but generally that isn't even
> initialized as far as I can tell, and we have things like
> dev_of_node() helpers to make sure you don't do that.
> 

I am sorry to make things break, Nicolai Stange's found the root cause
for this problem, and his patch fixed it.

USB device structure (both struct usb_hcd and struct usb_device) is
initialized by kzalloc, so the struct device in it is initialized by
zero, and will not cause non-initialized for USB device, but you
are right, a good practice is using dev_of_node for all devices in
case the struct device is not zero-initialized.

-- 

Best Regards,
Peter Chen

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web