Re: [GIT PULL] USB driver patches for 4.6-rc1

From	Peter Chen <hzpeterchen@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] USB driver patches for 4.6-rc1
Date	2016-03-20 12:40 +0100
Message-ID	<reJSa-6dX-17@gated-at.bofh.it> (permalink)
References	<rdtFN-865-29@gated-at.bofh.it> <rearp-11p-29@gated-at.bofh.it> <reaB4-1dO-17@gated-at.bofh.it> <rebx8-2Fl-5@gated-at.bofh.it> <rebGO-36E-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 18, 2016 at 04:01:51PM -0700, Linus Torvalds wrote:
> On Fri, Mar 18, 2016 at 3:51 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > The commit that ends up being marked bad is odd, but there it is:
> > 69bec7259853 "USB: core: let USB device know device node".
> 
> Confirmed. Not only did it bisect to that, reverting it on top of the
> current kernel fixes my machine.
> 
> So that commit is somehow buggy. I don't see what it does that would
> break even with OF disabled, but something does.
> 
> I'll just revert it. The way it is done seems bogus anyway.  It looks
> at of_node when OF is disabled, but generally that isn't even
> initialized as far as I can tell, and we have things like
> dev_of_node() helpers to make sure you don't do that.
> 

I am sorry to make things break, Nicolai Stange's found the root cause
for this problem, and his patch fixed it.

USB device structure (both struct usb_hcd and struct usb_device) is
initialized by kzalloc, so the struct device in it is initialized by
zero, and will not cause non-initialized for USB device, but you
are right, a good practice is using dev_of_node for all devices in
case the struct device is not zero-initialized.

-- 

Best Regards,
Peter Chen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-18 22:50 +0100
  Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-18 23:00 +0100
    Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-18 23:20 +0100
      Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-18 23:30 +0100
    Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:00 +0100
      Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-19 00:00 +0100
        Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:20 +0100
          Re: [GIT PULL] USB driver patches for 4.6-rc1 Greg KH <gregkh@linuxfoundation.org> - 2016-03-19 00:20 +0100
      Re: [GIT PULL] USB driver patches for 4.6-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-03-19 00:10 +0100
        Re: [GIT PULL] USB driver patches for 4.6-rc1 Peter Chen <hzpeterchen@gmail.com> - 2016-03-20 12:40 +0100

csiph-web