Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1359671 > unrolled thread

[PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

Started byAlexey Brodkin <Alexey.Brodkin@synopsys.com>
First post2016-03-17 10:50 +0100
Last post2016-03-17 13:20 +0100
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 10:50 +0100
    Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 12:00 +0100
      Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 12:20 +0100
      Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 12:40 +0100
        Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 12:50 +0100
          Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 13:00 +0100
            Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 13:20 +0100
            Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 13:20 +0100

#1359671 — [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2016-03-17 10:50 +0100
Subject[PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts
Message-ID<rdCJ3-5Dp-3@gated-at.bofh.it>
Following commit broke DW GMAC functionality on AXS10x boards:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

That's what happens on eth0 up:
--------------------------->8------------------------
libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
--------------------------->8------------------------

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Phil Reid <preid@electromag.com.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org # 4.5.x
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---

Changes v1 -> v2:
 * PHY node name changed to match real PHY number being used (Sergei)

 arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c..ab5d570 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
 			clocks = <&apbclk>;
 			clock-names = "stmmaceth";
 			max-speed = <100>;
+			mdio0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "snps,dwmac-mdio";
+				phy1: ethernet-phy@1 {
+					reg = <1>;
+				};
+			};
 		};
 
 		ehci@0x40000 {
-- 
2.5.0

[toc] | [next] | [standalone]

#1359732

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-03-17 12:00 +0100
Message-ID<rdDOO-6iN-9@gated-at.bofh.it>
In reply to#1359671
On 3/17/2016 12:41 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763

    Note that scripts/checkpatch.pl now enforces certain format for citing 
commits: commit <12-digit SHA1> ("<commit summary>").

[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1359743

FromVineet Gupta <Vineet.Gupta1@synopsys.com>
Date2016-03-17 12:20 +0100
Message-ID<rdE8a-6IF-25@gated-at.bofh.it>
In reply to#1359732
On Thursday 17 March 2016 04:28 PM, Sergei Shtylyov wrote:
> On 3/17/2016 12:41 PM, Alexey Brodkin wrote:
>
>> > Following commit broke DW GMAC functionality on AXS10x boards:
>> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>     Note that scripts/checkpatch.pl now enforces certain format for citing 
> commits: commit <12-digit SHA1> ("<commit summary>").
>
> [...]
>
> MBR, Sergei

Indeed - I've fixed this up and added to arc for-curr !

-Vineet

[toc] | [prev] | [next] | [standalone]

#1359754

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2016-03-17 12:40 +0100
Message-ID<rdErv-6Pk-7@gated-at.bofh.it>
In reply to#1359732
Hi Sergei,

On Thu, 2016-03-17 at 13:58 +-0300, Sergei Shtylyov wrote:
+AD4- On 3/17/2016 12:41 PM, Alexey Brodkin wrote:
+AD4- 
+AD4- +AD4- 
+AD4- +AD4- Following commit broke DW GMAC functionality on AXS10x boards:
+AD4- +AD4- http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id+AD0-e34d65696d2ef13dc32f2a162556c86c461ed763
+AD4- +AKAAoACgAKA-Note that scripts/checkpatch.pl now enforces certain format for citing+AKA-
+AD4- commits: commit +ADw-12-digit SHA1+AD4- (+ACIAPA-commit summary+AD4AIg-).

Frankly I haven't run that patch through checkpatch due to patch
simplicity.

But I'll try to not do any assumptions from now on and will try to
use checkpatch for each and every thing I send :)

Thanks for spotting all his+ACE-

-Alexey

[toc] | [prev] | [next] | [standalone]

#1359765

FromVineet Gupta <Vineet.Gupta1@synopsys.com>
Date2016-03-17 12:50 +0100
Message-ID<rdEBc-6TE-15@gated-at.bofh.it>
In reply to#1359754
On Thursday 17 March 2016 05:08 PM, Alexey Brodkin wrote:
> Hi Sergei,
>
> On Thu, 2016-03-17 at 13:58 +0300, Sergei Shtylyov wrote:
>> On 3/17/2016 12:41 PM, Alexey Brodkin wrote:
>>
>>> Following commit broke DW GMAC functionality on AXS10x boards:
>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>     Note that scripts/checkpatch.pl now enforces certain format for citing 
>> commits: commit <12-digit SHA1> ("<commit summary>").
> Frankly I haven't run that patch through checkpatch due to patch
> simplicity.
>
> But I'll try to not do any assumptions from now on and will try to
> use checkpatch for each and every thing I send :)
>
> Thanks for spotting all his!
>
> -Alexey

Sergei, do you mind providing a Ack/Reviewed-by on the patch below

-------->
From 67216d835d8c2a5748ba1631c8bfc19da4fb87fa Mon Sep 17 00:00:00 2001
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Thu, 17 Mar 2016 12:41:52 +0300
Subject: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts

Commit e34d65696d2e ("stmmac: create of compatible mdio bus for stmmac
driver") broke DW GMAC functionality on ARC AXS10x boards:

That's what happens on eth0 up:
  --------------------------->8------------------------
| libphy: PHY stmmac-0:ffffffff not found
| eth0: Could not attach to PHY
| stmmac_open: Cannot attach to PHY (error: -19)
  --------------------------->8------------------------

Simplest solution is to add PHY description in board's .dts.
And so we do here.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Phil Reid <preid@electromag.com.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: stable@vger.kernel.org # 4.5
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 44a578c10732..ab5d5701e11d 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -47,6 +47,14 @@
             clocks = <&apbclk>;
             clock-names = "stmmaceth";
             max-speed = <100>;
+            mdio0 {
+                #address-cells = <1>;
+                #size-cells = <0>;
+                compatible = "snps,dwmac-mdio";
+                phy1: ethernet-phy@1 {
+                    reg = <1>;
+                };
+            };
         };
 
         ehci@0x40000 {
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1359771

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-03-17 13:00 +0100
Message-ID<rdEKS-6X2-13@gated-at.bofh.it>
In reply to#1359765
Hello.

On 3/17/2016 2:41 PM, Vineet Gupta wrote:

>>>> Following commit broke DW GMAC functionality on AXS10x boards:
>>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>>      Note that scripts/checkpatch.pl now enforces certain format for citing
>>> commits: commit <12-digit SHA1> ("<commit summary>").

>> Frankly I haven't run that patch through checkpatch due to patch
>> simplicity.
>>
>> But I'll try to not do any assumptions from now on and will try to
>> use checkpatch for each and every thing I send :)
>>
>> Thanks for spotting all his!
>>

    Sorry for not reporting everything on the 1st review.

>> -Alexey
>
> Sergei, do you mind providing a Ack/Reviewed-by on the patch below
 >

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    The patch here is white space damaged however: tabs were converted to 
spaces. :-(

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1359794

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2016-03-17 13:20 +0100
Message-ID<rdF4d-7ki-1@gated-at.bofh.it>
In reply to#1359771
Hi Sergei,

On Thu, 2016-03-17 at 14:59 +-0300, Sergei Shtylyov wrote:
+AD4- Hello.
+AD4- 
+AD4- On 3/17/2016 2:41 PM, Vineet Gupta wrote:
+AD4- 
+AD4- +AD4- 
+AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- +AD4- +AD4- Following commit broke DW GMAC functionality on AXS10x boards:
+AD4- +AD4- +AD4- +AD4- +AD4- http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id+AD0-e34d65696d2ef13dc32f2a162556c86c461e
+AD4- +AD4- +AD4- +AD4- +AD4- d763
+AD4- +AD4- +AD4- +AD4- +AKAAoACgAKAAoA-Note that scripts/checkpatch.pl now enforces certain format for citing
+AD4- +AD4- +AD4- +AD4- commits: commit +ADw-12-digit SHA1+AD4- (+ACIAPA-commit summary+AD4AIg-).
+AD4- +AD4- 
+AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- Frankly I haven't run that patch through checkpatch due to patch
+AD4- +AD4- +AD4- simplicity.
+AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- But I'll try to not do any assumptions from now on and will try to
+AD4- +AD4- +AD4- use checkpatch for each and every thing I send :)
+AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- Thanks for spotting all his+ACE-
+AD4- +AD4- +AD4- 
+AD4- +AKAAoACgAKA-Sorry for not reporting everything on the 1st review.
+AD4- 
+AD4- +AD4- 
+AD4- +AD4- +AD4- 
+AD4- +AD4- +AD4- -Alexey
+AD4- +AD4- Sergei, do you mind providing a Ack/Reviewed-by on the patch below
+AD4- +AKAAPg-
+AD4- 
+AD4- Reviewed-by: Sergei Shtylyov +ADw-sergei.shtylyov+AEA-cogentembedded.com+AD4-
+AD4- 
+AD4- +AKAAoACgAKA-The patch here is white space damaged however: tabs were converted to+AKA-
+AD4- spaces. :-(

Well, I'm not really sure why that substitution happened because my local patch
is indeed with tabs.

That's an output of checkpatch:
------------------------+AD4-8------------------------
./scripts/checkpatch.pl 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch+AKA-
+AFs-1+AF0AKwCgAKA-Done+AKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoA-gedit 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
+ACM-7:+AKA-
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id+AD0-e34d65696d2ef13dc32f2a162556c86c461ed763

ERROR: Please use git commit description style 'commit +ADw-12+- chars of sha1+AD4- (+ACIAPA-title line+AD4AIg-)' - ie: 'commit e34d65696d2e
(+ACI-stmmac: create of compatible mdio bus for stmmac driver+ACI-)'
+ACM-7:+AKA-
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id+AD0-e34d65696d2ef13dc32f2a162556c86c461ed763

total: 1 errors, 1 warnings, 14 lines checked

0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch has style problems, please review.
------------------------+AD4-8------------------------

If there were spaces we would see tons of:
------------------------+AD4-8------------------------
ERROR: code indent should use tabs where possible
+ACM-43: FILE: arch/arc/boot/dts/axs10x+AF8-mb.dtsi:50:
+-+AKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACgAKAAoACg-mdio0 +AHsAJA-
------------------------+AD4-8------------------------
which I didn't see.

-Alexey

[toc] | [prev] | [next] | [standalone]

#1359799

FromVineet Gupta <Vineet.Gupta1@synopsys.com>
Date2016-03-17 13:20 +0100
Message-ID<rdF4e-7ki-19@gated-at.bofh.it>
In reply to#1359771
On Thursday 17 March 2016 05:29 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 3/17/2016 2:41 PM, Vineet Gupta wrote:
>
>>>>> >>>> Following commit broke DW GMAC functionality on AXS10x boards:
>>>>> >>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>>> >>>      Note that scripts/checkpatch.pl now enforces certain format for citing
>>>> >>> commits: commit <12-digit SHA1> ("<commit summary>").
>>> >> Frankly I haven't run that patch through checkpatch due to patch
>>> >> simplicity.
>>> >>
>>> >> But I'll try to not do any assumptions from now on and will try to
>>> >> use checkpatch for each and every thing I send :)
>>> >>
>>> >> Thanks for spotting all his!
>>> >>
>     Sorry for not reporting everything on the 1st review.
>
>>> >> -Alexey
>> >
>> > Sergei, do you mind providing a Ack/Reviewed-by on the patch below
>  >
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thx.

>     The patch here is white space damaged however: tabs were converted to 
> spaces. :-(
>
> MBR, Sergei


That was just because of copy-paste into mailer before switching to plain-text.
Don't ask - corporate email !
I added it just to give u an idea of what fixup i did.

Tx,
-Vineet

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web