Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts
Date	2016-03-17 13:20 +0100
Message-ID	<rdF4e-7ki-19@gated-at.bofh.it> (permalink)
References	<rdCJ3-5Dp-3@gated-at.bofh.it> <rdDOO-6iN-9@gated-at.bofh.it> <rdErv-6Pk-7@gated-at.bofh.it> <rdEBc-6TE-15@gated-at.bofh.it> <rdEKS-6X2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 17 March 2016 05:29 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 3/17/2016 2:41 PM, Vineet Gupta wrote:
>
>>>>> >>>> Following commit broke DW GMAC functionality on AXS10x boards:
>>>>> >>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>>> >>>      Note that scripts/checkpatch.pl now enforces certain format for citing
>>>> >>> commits: commit <12-digit SHA1> ("<commit summary>").
>>> >> Frankly I haven't run that patch through checkpatch due to patch
>>> >> simplicity.
>>> >>
>>> >> But I'll try to not do any assumptions from now on and will try to
>>> >> use checkpatch for each and every thing I send :)
>>> >>
>>> >> Thanks for spotting all his!
>>> >>
>     Sorry for not reporting everything on the 1st review.
>
>>> >> -Alexey
>> >
>> > Sergei, do you mind providing a Ack/Reviewed-by on the patch below
>  >
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thx.

>     The patch here is white space damaged however: tabs were converted to 
> spaces. :-(
>
> MBR, Sergei


That was just because of copy-paste into mailer before switching to plain-text.
Don't ask - corporate email !
I added it just to give u an idea of what fixup i did.

Tx,
-Vineet

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 10:50 +0100
  Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 12:00 +0100
    Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 12:20 +0100
    Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 12:40 +0100
      Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 12:50 +0100
        Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-17 13:00 +0100
          Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-03-17 13:20 +0100
          Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-03-17 13:20 +0100

csiph-web