Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357844 > unrolled thread

[patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

Started byDan Carpenter <dan.carpenter@oracle.com>
First post2016-03-15 08:20 +0100
Last post2016-03-16 00:50 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-15 08:20 +0100
    Re: [patch] Input: synaptics-rmi4 - using logical instead of  bitwise AND Joe Perches <joe@perches.com> - 2016-03-15 09:40 +0100
      Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise  AND Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-15 09:40 +0100
        Re: [patch] Input: synaptics-rmi4 - using logical instead of  bitwise AND Joe Perches <joe@perches.com> - 2016-03-15 10:00 +0100
    Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise  AND Andrew Duggan <aduggan@synaptics.com> - 2016-03-15 22:30 +0100
      Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise  AND Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-03-16 00:50 +0100

#1357844 — [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-03-15 08:20 +0100
Subject[patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rcRqO-7hA-13@gated-at.bofh.it>
There is a typo so we have && instead of &.

Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index 77a5eb8..ec8a10d 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
 	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
 	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
 	sensor_query->has_sensitivity_adjust =
-		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
 	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
 
 	sensor_query->nr_x_electrodes =
@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
 		sensor_query->has_bending_correction =
 			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
 		sensor_query->has_large_object_suppression =
-		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
+			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
 		sensor_query->has_jitter_filter =
 			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
 		query_size++;

[toc] | [next] | [standalone]

#1357899 — Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromJoe Perches <joe@perches.com>
Date2016-03-15 09:40 +0100
SubjectRe: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rcSGe-81d-5@gated-at.bofh.it>
In reply to#1357844
On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote:
> There is a typo so we have && instead of &.
> 
> Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
[]
> @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
>  	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
>  	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
>  	sensor_query->has_sensitivity_adjust =
> -		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> +		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
>  	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
>  
>  	sensor_query->nr_x_electrodes =
> @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
>  		sensor_query->has_bending_correction =
>  			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
>  		sensor_query->has_large_object_suppression =
> -		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> +			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
>  		sensor_query->has_jitter_filter =
>  			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
>  		query_size++;

Right and as well these are bool so the !! isn't necessary.

[toc] | [prev] | [next] | [standalone]

#1357900 — Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-03-15 09:40 +0100
SubjectRe: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rcSGe-81d-7@gated-at.bofh.it>
In reply to#1357899
On Tue, Mar 15, 2016 at 01:33:29AM -0700, Joe Perches wrote:
> Right and as well these are bool so the !! isn't necessary.

Not necessary but nice for reading...

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1357918 — Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromJoe Perches <joe@perches.com>
Date2016-03-15 10:00 +0100
SubjectRe: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rcSZA-88c-19@gated-at.bofh.it>
In reply to#1357900
On Tue, 2016-03-15 at 11:37 +0300, Dan Carpenter wrote:
> On Tue, Mar 15, 2016 at 01:33:29AM -0700, Joe Perches wrote:
> > 
> > Right and as well these are bool so the !! isn't necessary.
> Not necessary but nice for reading...

<shrug> opinions vary.

cheers, Joe

[toc] | [prev] | [next] | [standalone]

#1358255 — Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromAndrew Duggan <aduggan@synaptics.com>
Date2016-03-15 22:30 +0100
SubjectRe: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rd4Ho-7Mu-5@gated-at.bofh.it>
In reply to#1357844
On 03/15/2016 12:11 AM, Dan Carpenter wrote:
> There is a typo so we have && instead of &.
>
> Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Andrew Duggan <aduggan@synaptics.com>

> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 77a5eb8..ec8a10d 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
>   	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
>   	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
>   	sensor_query->has_sensitivity_adjust =
> -		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> +		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
>   	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
>   
>   	sensor_query->nr_x_electrodes =
> @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
>   		sensor_query->has_bending_correction =
>   			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
>   		sensor_query->has_large_object_suppression =
> -		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> +			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
>   		sensor_query->has_jitter_filter =
>   			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
>   		query_size++;

[toc] | [prev] | [next] | [standalone]

#1358386 — Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-03-16 00:50 +0100
SubjectRe: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Message-ID<rd6SS-Ip-23@gated-at.bofh.it>
In reply to#1358255
On Tue, Mar 15, 2016 at 02:20:02PM -0700, Andrew Duggan wrote:
> On 03/15/2016 12:11 AM, Dan Carpenter wrote:
> >There is a typo so we have && instead of &.
> >
> >Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Acked-by: Andrew Duggan <aduggan@synaptics.com>

Applied, thank you.

> 
> >diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> >index 77a5eb8..ec8a10d 100644
> >--- a/drivers/input/rmi4/rmi_f11.c
> >+++ b/drivers/input/rmi4/rmi_f11.c
> >@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> >  	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
> >  	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
> >  	sensor_query->has_sensitivity_adjust =
> >-		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> >+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
> >  	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
> >  	sensor_query->nr_x_electrodes =
> >@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> >  		sensor_query->has_bending_correction =
> >  			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
> >  		sensor_query->has_large_object_suppression =
> >-		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> >+			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> >  		sensor_query->has_jitter_filter =
> >  			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
> >  		query_size++;
> 

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web