Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1358255
| From | Andrew Duggan <aduggan@synaptics.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND |
| Date | 2016-03-15 22:30 +0100 |
| Message-ID | <rd4Ho-7Mu-5@gated-at.bofh.it> (permalink) |
| References | <rcRqO-7hA-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/15/2016 12:11 AM, Dan Carpenter wrote:
> There is a typo so we have && instead of &.
>
> Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Andrew Duggan <aduggan@synaptics.com>
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 77a5eb8..ec8a10d 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
> sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
> sensor_query->has_sensitivity_adjust =
> - !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
> sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
>
> sensor_query->nr_x_electrodes =
> @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> sensor_query->has_bending_correction =
> !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
> sensor_query->has_large_object_suppression =
> - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> sensor_query->has_jitter_filter =
> !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
> query_size++;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-15 08:20 +0100
Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Joe Perches <joe@perches.com> - 2016-03-15 09:40 +0100
Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-15 09:40 +0100
Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Joe Perches <joe@perches.com> - 2016-03-15 10:00 +0100
Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Andrew Duggan <aduggan@synaptics.com> - 2016-03-15 22:30 +0100
Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-03-16 00:50 +0100
csiph-web