Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1358033 > unrolled thread

[PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers

Started byChristophe Leroy <christophe.leroy@c-s.fr>
First post2016-03-15 14:10 +0100
Last post2016-03-16 11:30 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers Christophe Leroy <christophe.leroy@c-s.fr> - 2016-03-15 14:10 +0100
    Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older  compilers Scott Wood <oss@buserror.net> - 2016-03-15 18:50 +0100
      Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older  compilers christophe leroy <christophe.leroy@c-s.fr> - 2016-03-15 19:20 +0100
    Re: [v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers Michael Ellerman <mpe@ellerman.id.au> - 2016-03-16 11:30 +0100

#1358033 — [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers

FromChristophe Leroy <christophe.leroy@c-s.fr>
Date2016-03-15 14:10 +0100
Subject[PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers
Message-ID<rcWTw-2vY-11@gated-at.bofh.it>
Some versions of GCC, reportedly before 4.8, fail with
arch/powerpc/mm/8xx_mmu.c:139:2: error: memory input 1 is not directly
addressable

Change the one-element array into a simple variable to avoid this.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Scott Wood <oss@buserror.net>
---
Verified with GCC 4.4.4 and GCC 4.8.3

v2: compilation result is compliant with CPU6 ERRATA
    (using stw/lwz and not stwx/lwzx)

 arch/powerpc/include/asm/reg_8xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/reg_8xx.h b/arch/powerpc/include/asm/reg_8xx.h
index d41412c..94d01f8 100644
--- a/arch/powerpc/include/asm/reg_8xx.h
+++ b/arch/powerpc/include/asm/reg_8xx.h
@@ -53,7 +53,7 @@
 #ifdef CONFIG_8xx_CPU6
 #define do_mtspr_cpu6(rn, rn_addr, v)	\
 	do {								\
-		int _reg_cpu6 = rn_addr, _tmp_cpu6[1];		\
+		int _reg_cpu6 = rn_addr, _tmp_cpu6;		\
 		asm volatile("stw %0, %1;"				\
 			     "lwz %0, %1;"				\
 			     "mtspr " __stringify(rn) ",%2" :		\
-- 
2.1.0

[toc] | [next] | [standalone]

#1358176 — Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers

FromScott Wood <oss@buserror.net>
Date2016-03-15 18:50 +0100
SubjectRe: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers
Message-ID<rd1gu-5fB-7@gated-at.bofh.it>
In reply to#1358033
On Tue, 2016-03-15 at 14:07 +0100, Christophe Leroy wrote:
> Some versions of GCC, reportedly before 4.8, fail with
> arch/powerpc/mm/8xx_mmu.c:139:2: error: memory input 1 is not directly
> addressable

"before 4.8" means "< 4.8", not "<= 4.8" -- did you mean "before 4.9"?

> Change the one-element array into a simple variable to avoid this.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Scott Wood <oss@buserror.net>
> ---
> Verified with GCC 4.4.4 and GCC 4.8.3
> 
> v2: compilation result is compliant with CPU6 ERRATA
>     (using stw/lwz and not stwx/lwzx)
> 
>  arch/powerpc/include/asm/reg_8xx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/include/asm/reg_8xx.h
> b/arch/powerpc/include/asm/reg_8xx.h
> index d41412c..94d01f8 100644
> --- a/arch/powerpc/include/asm/reg_8xx.h
> +++ b/arch/powerpc/include/asm/reg_8xx.h
> @@ -53,7 +53,7 @@
>  #ifdef CONFIG_8xx_CPU6
>  #define do_mtspr_cpu6(rn, rn_addr, v)	\
>  	do {								
> \
> -		int _reg_cpu6 = rn_addr, _tmp_cpu6[1];		\
> +		int _reg_cpu6 = rn_addr, _tmp_cpu6;		\
>  		asm volatile("stw %0, %1;"				\
>  			     "lwz %0, %1;"				\
>  			     "mtspr " __stringify(rn) ",%2" :		
> \

I thought I tried this with 4.7.2 without success, but now it seems to be
working...

-Scott

[toc] | [prev] | [next] | [standalone]

#1358182 — Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers

Fromchristophe leroy <christophe.leroy@c-s.fr>
Date2016-03-15 19:20 +0100
SubjectRe: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers
Message-ID<rd1Jw-5Km-11@gated-at.bofh.it>
In reply to#1358176

Le 15/03/2016 18:41, Scott Wood a écrit :
> On Tue, 2016-03-15 at 14:07 +0100, Christophe Leroy wrote:
>> Some versions of GCC, reportedly before 4.8, fail with
>> arch/powerpc/mm/8xx_mmu.c:139:2: error: memory input 1 is not directly
>> addressable
> "before 4.8" means "< 4.8", not "<= 4.8" -- did you mean "before 4.9"?
I mean it doesn't fail with 4.8.3

Christophe
>
>> Change the one-element array into a simple variable to avoid this.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> Cc: Scott Wood <oss@buserror.net>
>> ---
>> Verified with GCC 4.4.4 and GCC 4.8.3
>>
>> v2: compilation result is compliant with CPU6 ERRATA
>>      (using stw/lwz and not stwx/lwzx)
>>
>>   arch/powerpc/include/asm/reg_8xx.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/reg_8xx.h
>> b/arch/powerpc/include/asm/reg_8xx.h
>> index d41412c..94d01f8 100644
>> --- a/arch/powerpc/include/asm/reg_8xx.h
>> +++ b/arch/powerpc/include/asm/reg_8xx.h
>> @@ -53,7 +53,7 @@
>>   #ifdef CONFIG_8xx_CPU6
>>   #define do_mtspr_cpu6(rn, rn_addr, v)	\
>>   	do {								
>> \
>> -		int _reg_cpu6 = rn_addr, _tmp_cpu6[1];		\
>> +		int _reg_cpu6 = rn_addr, _tmp_cpu6;		\
>>   		asm volatile("stw %0, %1;"				\
>>   			     "lwz %0, %1;"				\
>>   			     "mtspr " __stringify(rn) ",%2" :		
>> \
> I thought I tried this with 4.7.2 without success, but now it seems to be
> working...
>
> -Scott
>


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

[toc] | [prev] | [next] | [standalone]

#1358803 — Re: [v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers

FromMichael Ellerman <mpe@ellerman.id.au>
Date2016-03-16 11:30 +0100
SubjectRe: [v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers
Message-ID<rdgSe-7Ep-9@gated-at.bofh.it>
In reply to#1358033
On Tue, 2016-15-03 at 13:07:49 UTC, Christophe Leroy wrote:
> Some versions of GCC, reportedly before 4.8, fail with
> arch/powerpc/mm/8xx_mmu.c:139:2: error: memory input 1 is not directly
> addressable
> 
> Change the one-element array into a simple variable to avoid this.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Scott Wood <oss@buserror.net>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/2e098dcee6208a690f73e11feb

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web