Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1358176
| From | Scott Wood <oss@buserror.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers |
| Date | 2016-03-15 18:50 +0100 |
| Message-ID | <rd1gu-5fB-7@gated-at.bofh.it> (permalink) |
| References | <rcWTw-2vY-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-03-15 at 14:07 +0100, Christophe Leroy wrote:
> Some versions of GCC, reportedly before 4.8, fail with
> arch/powerpc/mm/8xx_mmu.c:139:2: error: memory input 1 is not directly
> addressable
"before 4.8" means "< 4.8", not "<= 4.8" -- did you mean "before 4.9"?
> Change the one-element array into a simple variable to avoid this.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Scott Wood <oss@buserror.net>
> ---
> Verified with GCC 4.4.4 and GCC 4.8.3
>
> v2: compilation result is compliant with CPU6 ERRATA
> (using stw/lwz and not stwx/lwzx)
>
> arch/powerpc/include/asm/reg_8xx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/reg_8xx.h
> b/arch/powerpc/include/asm/reg_8xx.h
> index d41412c..94d01f8 100644
> --- a/arch/powerpc/include/asm/reg_8xx.h
> +++ b/arch/powerpc/include/asm/reg_8xx.h
> @@ -53,7 +53,7 @@
> #ifdef CONFIG_8xx_CPU6
> #define do_mtspr_cpu6(rn, rn_addr, v) \
> do {
> \
> - int _reg_cpu6 = rn_addr, _tmp_cpu6[1]; \
> + int _reg_cpu6 = rn_addr, _tmp_cpu6; \
> asm volatile("stw %0, %1;" \
> "lwz %0, %1;" \
> "mtspr " __stringify(rn) ",%2" :
> \
I thought I tried this with 4.7.2 without success, but now it seems to be
working...
-Scott
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers Christophe Leroy <christophe.leroy@c-s.fr> - 2016-03-15 14:10 +0100
Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers Scott Wood <oss@buserror.net> - 2016-03-15 18:50 +0100
Re: [PATCH v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers christophe leroy <christophe.leroy@c-s.fr> - 2016-03-15 19:20 +0100
Re: [v2] powerpc/8xx: Fix do_mtspr_cpu6 build on older compilers Michael Ellerman <mpe@ellerman.id.au> - 2016-03-16 11:30 +0100
csiph-web