Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1351677 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2016-03-07 16:00 +0100 |
| Last post | 2016-03-08 13:50 +0100 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/7] leds: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
[PATCH 6/7] leds: max8997: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
[PATCH 2/7] leds: lp8788: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
[PATCH 1/7] leds: 88pm860x: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
Re: [PATCH 0/7] leds: Use devm_led_classdev_register Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-08 09:30 +0100
Re: [PATCH 0/7] leds: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-08 13:50 +0100
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-03-07 16:00 +0100 |
| Subject | [PATCH 0/7] leds: Use devm_led_classdev_register |
| Message-ID | <ra4Nz-49R-3@gated-at.bofh.it> |
Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.
The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>
Amitoj Kaur Chawla (7):
leds: 88pm860x: Use devm_led_classdev_register
leds: lp8788: Use devm_led_classdev_register
leds: wm381x-status: Use devm_led_classdev_register
leds: s3c24xx: Use devm_led_classdev_register
leds: da903x: Use devm_led_classdev_register
leds: max8997: Use devm_led_classdev_register
leds: lm3533: Use devm_led_classdev_register
drivers/leds/leds-88pm860x.c | 11 +----------
drivers/leds/leds-da903x.c | 11 +----------
drivers/leds/leds-lm3533.c | 12 +++---------
drivers/leds/leds-lp8788.c | 12 +-----------
drivers/leds/leds-max8997.c | 12 +-----------
drivers/leds/leds-s3c24xx.c | 12 +-----------
drivers/leds/leds-wm831x-status.c | 12 +-----------
7 files changed, 9 insertions(+), 73 deletions(-)
--
1.9.1
[toc] | [next] | [standalone]
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-03-07 16:00 +0100 |
| Subject | [PATCH 6/7] leds: max8997: Use devm_led_classdev_register |
| Message-ID | <ra4NA-49R-31@gated-at.bofh.it> |
| In reply to | #1351677 |
Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.
Also, remove max8997_led_remove as it is now has nothing to do.
The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/leds/leds-max8997.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c
index 01b45906..2387e35 100644
--- a/drivers/leds/leds-max8997.c
+++ b/drivers/leds/leds-max8997.c
@@ -283,28 +283,18 @@ static int max8997_led_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, led);
- ret = led_classdev_register(&pdev->dev, &led->cdev);
+ ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
if (ret < 0)
return ret;
return 0;
}
-static int max8997_led_remove(struct platform_device *pdev)
-{
- struct max8997_led *led = platform_get_drvdata(pdev);
-
- led_classdev_unregister(&led->cdev);
-
- return 0;
-}
-
static struct platform_driver max8997_led_driver = {
.driver = {
.name = "max8997-led",
},
.probe = max8997_led_probe,
- .remove = max8997_led_remove,
};
module_platform_driver(max8997_led_driver);
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-03-07 16:00 +0100 |
| Subject | [PATCH 2/7] leds: lp8788: Use devm_led_classdev_register |
| Message-ID | <ra4NB-49R-33@gated-at.bofh.it> |
| In reply to | #1351677 |
Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.
Also, remove lp8788_led_remove as it is now has nothing to do.
The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/leds/leds-lp8788.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/leds/leds-lp8788.c b/drivers/leds/leds-lp8788.c
index 0eee38f..ffc3f89 100644
--- a/drivers/leds/leds-lp8788.c
+++ b/drivers/leds/leds-lp8788.c
@@ -154,7 +154,7 @@ static int lp8788_led_probe(struct platform_device *pdev)
return ret;
}
- ret = led_classdev_register(dev, &led->led_dev);
+ ret = devm_led_classdev_register(dev, &led->led_dev);
if (ret) {
dev_err(dev, "led register err: %d\n", ret);
return ret;
@@ -163,18 +163,8 @@ static int lp8788_led_probe(struct platform_device *pdev)
return 0;
}
-static int lp8788_led_remove(struct platform_device *pdev)
-{
- struct lp8788_led *led = platform_get_drvdata(pdev);
-
- led_classdev_unregister(&led->led_dev);
-
- return 0;
-}
-
static struct platform_driver lp8788_led_driver = {
.probe = lp8788_led_probe,
- .remove = lp8788_led_remove,
.driver = {
.name = LP8788_DEV_KEYLED,
},
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-03-07 16:00 +0100 |
| Subject | [PATCH 1/7] leds: 88pm860x: Use devm_led_classdev_register |
| Message-ID | <ra4NB-49R-35@gated-at.bofh.it> |
| In reply to | #1351677 |
Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.
Also, remove pm860x_led_remove as it is now has nothing to do.
The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/leds/leds-88pm860x.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1ad4d03..16cfb3d 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -208,7 +208,7 @@ static int pm860x_led_probe(struct platform_device *pdev)
data->cdev.brightness_set_blocking = pm860x_led_set;
mutex_init(&data->lock);
- ret = led_classdev_register(chip->dev, &data->cdev);
+ ret = devm_led_classdev_register(chip->dev, &data->cdev);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to register LED: %d\n", ret);
return ret;
@@ -217,21 +217,12 @@ static int pm860x_led_probe(struct platform_device *pdev)
return 0;
}
-static int pm860x_led_remove(struct platform_device *pdev)
-{
- struct pm860x_led *data = platform_get_drvdata(pdev);
-
- led_classdev_unregister(&data->cdev);
-
- return 0;
-}
static struct platform_driver pm860x_led_driver = {
.driver = {
.name = "88pm860x-led",
},
.probe = pm860x_led_probe,
- .remove = pm860x_led_remove,
};
module_platform_driver(pm860x_led_driver);
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-03-08 09:30 +0100 |
| Message-ID | <ralbI-6LY-15@gated-at.bofh.it> |
| In reply to | #1351677 |
Hi Amitoj,
Thanks for the patches.
Applied only the 7/7 one. In the remaining ones, please remove
also all occurrences of platform_set_drvdata() in the probe()
and pdev_to_gpio() definition from leds-s3c24xx.cm as they will
be no longer required.
Best regards,
Jacek Anaszewski
On 03/07/2016 03:50 PM, Amitoj Kaur Chawla wrote:
> Switch to resource-managed function devm_led_classdev_register instead
> of led_classdev_register and remove unneeded led_classdev_unregister.
>
> The Coccinelle semantic patch used to make this change is as follows:
> //<smpl>
> @platform@
> identifier p, probefn, removefn;
> @@
> struct platform_driver p = {
> .probe = probefn,
> .remove = removefn,
> };
>
> @prb@
> identifier platform.probefn, pdev;
> expression e;
> @@
> probefn(struct platform_device *pdev, ...) {
> ...
> e =
> - led_classdev_register
> + devm_led_classdev_register
> (...);
> ...
> ?- led_classdev_unregister(...);
> ...
> }
> @remove depends on prb@
> identifier platform.removefn;
> @@
> removefn(...) {
> ...
> ?- led_classdev_unregister(...);
> ...
> }
> //</smpl>
>
> Amitoj Kaur Chawla (7):
> leds: 88pm860x: Use devm_led_classdev_register
> leds: lp8788: Use devm_led_classdev_register
> leds: wm381x-status: Use devm_led_classdev_register
> leds: s3c24xx: Use devm_led_classdev_register
> leds: da903x: Use devm_led_classdev_register
> leds: max8997: Use devm_led_classdev_register
> leds: lm3533: Use devm_led_classdev_register
>
> drivers/leds/leds-88pm860x.c | 11 +----------
> drivers/leds/leds-da903x.c | 11 +----------
> drivers/leds/leds-lm3533.c | 12 +++---------
> drivers/leds/leds-lp8788.c | 12 +-----------
> drivers/leds/leds-max8997.c | 12 +-----------
> drivers/leds/leds-s3c24xx.c | 12 +-----------
> drivers/leds/leds-wm831x-status.c | 12 +-----------
> 7 files changed, 9 insertions(+), 73 deletions(-)
>
[toc] | [prev] | [next] | [standalone]
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-03-08 13:50 +0100 |
| Message-ID | <rapfk-TU-25@gated-at.bofh.it> |
| In reply to | #1352740 |
On Tue, Mar 8, 2016 at 1:56 PM, Jacek Anaszewski <j.anaszewski@samsung.com> wrote: > Hi Amitoj, > > Thanks for the patches. > > Applied only the 7/7 one. In the remaining ones, please remove > also all occurrences of platform_set_drvdata() in the probe() > and pdev_to_gpio() definition from leds-s3c24xx.cm as they will > be no longer required. Okay, thanks for the feedback. Will do. Amitoj
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web