Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1351681

[PATCH 1/7] leds: 88pm860x: Use devm_led_classdev_register

Show all headers | View raw

Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove pm860x_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
  ...
  e =
- led_classdev_register
+ devm_led_classdev_register
  (...);
   ...
?- led_classdev_unregister(...);
  ...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/leds/leds-88pm860x.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1ad4d03..16cfb3d 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -208,7 +208,7 @@ static int pm860x_led_probe(struct platform_device *pdev)
 	data->cdev.brightness_set_blocking = pm860x_led_set;
 	mutex_init(&data->lock);
 
-	ret = led_classdev_register(chip->dev, &data->cdev);
+	ret = devm_led_classdev_register(chip->dev, &data->cdev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "Failed to register LED: %d\n", ret);
 		return ret;
@@ -217,21 +217,12 @@ static int pm860x_led_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int pm860x_led_remove(struct platform_device *pdev)
-{
-	struct pm860x_led *data = platform_get_drvdata(pdev);
-
-	led_classdev_unregister(&data->cdev);
-
-	return 0;
-}
 
 static struct platform_driver pm860x_led_driver = {
 	.driver	= {
 		.name	= "88pm860x-led",
 	},
 	.probe	= pm860x_led_probe,
-	.remove	= pm860x_led_remove,
 };
 
 module_platform_driver(pm860x_led_driver);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] leds: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
  [PATCH 6/7] leds: max8997: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
  [PATCH 2/7] leds: lp8788: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
  [PATCH 1/7] leds: 88pm860x: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-07 16:00 +0100
  Re: [PATCH 0/7] leds: Use devm_led_classdev_register Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-08 09:30 +0100
    Re: [PATCH 0/7] leds: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-08 13:50 +0100

csiph-web