Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1352943 > unrolled thread

[patch] libertas: fix an error code in probe

Back to article view | Back to linux.kernel

Contents

  [patch] libertas: fix an error code in probe Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-08 13:10 +0100
    Re: libertas: fix an error code in probe Kalle Valo <kvalo@codeaurora.org> - 2016-03-10 14:00 +0100

#1352943 — [patch] libertas: fix an error code in probe

We accidentally return success instead of a negative error code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c
index b35b8bc..8541cbe 100644
--- a/drivers/net/wireless/marvell/libertas/main.c
+++ b/drivers/net/wireless/marvell/libertas/main.c
@@ -1118,7 +1118,8 @@ int lbs_start_card(struct lbs_private *priv)
 	else
 		pr_info("%s: mesh disabled\n", dev->name);
 
-	if (lbs_cfg_register(priv)) {
+	ret = lbs_cfg_register(priv);
+	if (ret) {
 		pr_err("cannot register device\n");
 		goto done;
 	}

[toc] | [next] | [standalone]

#1355094 — Re: libertas: fix an error code in probe

> We accidentally return success instead of a negative error code.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web