Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1352943

[patch] libertas: fix an error code in probe

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject [patch] libertas: fix an error code in probe
Date 2016-03-08 13:10 +0100
Message-ID <raoCC-DB-15@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


We accidentally return success instead of a negative error code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c
index b35b8bc..8541cbe 100644
--- a/drivers/net/wireless/marvell/libertas/main.c
+++ b/drivers/net/wireless/marvell/libertas/main.c
@@ -1118,7 +1118,8 @@ int lbs_start_card(struct lbs_private *priv)
 	else
 		pr_info("%s: mesh disabled\n", dev->name);
 
-	if (lbs_cfg_register(priv)) {
+	ret = lbs_cfg_register(priv);
+	if (ret) {
 		pr_err("cannot register device\n");
 		goto done;
 	}

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[patch] libertas: fix an error code in probe Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-08 13:10 +0100
  Re: libertas: fix an error code in probe Kalle Valo <kvalo@codeaurora.org> - 2016-03-10 14:00 +0100

csiph-web