Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1352102 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2016-03-08 00:10 +0100 |
| Last post | 2016-03-10 01:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group Peter Zijlstra <peterz@infradead.org> - 2016-03-08 00:10 +0100
Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group Vikas Shivappa <vikas.shivappa@intel.com> - 2016-03-10 01:20 +0100
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-03-08 00:10 +0100 |
| Subject | Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group |
| Message-ID | <racrN-V4-43@gated-at.bofh.it> |
On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote:
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -121,6 +121,7 @@ struct hw_perf_event {
> struct { /* intel_cqm */
> int cqm_state;
> u32 cqm_rmid;
> + bool is_group_event;
> struct list_head cqm_events_entry;
> struct list_head cqm_groups_entry;
> struct list_head cqm_group_entry;
Please, no 'bool' in structures.
[toc] | [next] | [standalone]
| From | Vikas Shivappa <vikas.shivappa@intel.com> |
|---|---|
| Date | 2016-03-10 01:20 +0100 |
| Message-ID | <raWuB-7q3-1@gated-at.bofh.it> |
| In reply to | #1352102 |
On Mon, 7 Mar 2016, Peter Zijlstra wrote:
> On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote:
>> --- a/include/linux/perf_event.h
>> +++ b/include/linux/perf_event.h
>> @@ -121,6 +121,7 @@ struct hw_perf_event {
>> struct { /* intel_cqm */
>> int cqm_state;
>> u32 cqm_rmid;
>> + bool is_group_event;
>> struct list_head cqm_events_entry;
>> struct list_head cqm_groups_entry;
>> struct list_head cqm_group_entry;
>
> Please, no 'bool' in structures.
Will fix..
thanks,
vikas
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web