Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group

From	Vikas Shivappa <vikas.shivappa@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group
Date	2016-03-10 01:20 +0100
Message-ID	<raWuB-7q3-1@gated-at.bofh.it> (permalink)
References	<r82dc-7Iy-3@gated-at.bofh.it> <r82dd-7Iy-25@gated-at.bofh.it> <racrN-V4-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Mon, 7 Mar 2016, Peter Zijlstra wrote:

> On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote:
>> --- a/include/linux/perf_event.h
>> +++ b/include/linux/perf_event.h
>> @@ -121,6 +121,7 @@ struct hw_perf_event {
>>  		struct { /* intel_cqm */
>>  			int			cqm_state;
>>  			u32			cqm_rmid;
>> +			bool			is_group_event;
>>  			struct list_head	cqm_events_entry;
>>  			struct list_head	cqm_groups_entry;
>>  			struct list_head	cqm_group_entry;
>
> Please, no 'bool' in structures.

Will fix..

thanks,
vikas

>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events  into a cache_group Peter Zijlstra <peterz@infradead.org> - 2016-03-08 00:10 +0100
  Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events  into a cache_group Vikas Shivappa <vikas.shivappa@intel.com> - 2016-03-10 01:20 +0100

csiph-web