Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451221 > unrolled thread
| Started by | David Howells <dhowells@redhat.com> |
|---|---|
| First post | 2016-07-27 12:50 +0200 |
| Last post | 2016-08-01 12:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace David Howells <dhowells@redhat.com> - 2016-07-27 12:50 +0200
Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace Stephan Mueller <smueller@chronox.de> - 2016-07-27 13:30 +0200
[tip:x86/urgent] x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace tip-bot for David Howells <tipbot@zytor.com> - 2016-08-01 12:50 +0200
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-07-27 12:50 +0200 |
| Subject | [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace |
| Message-ID | <rZuzv-6GJ-7@gated-at.bofh.it> |
x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than calling sys_keyctl. The latter will work in a lot of cases, thereby hiding the issue. Reported-by: Stephan Mueller <smueller@chronox.de> Signed-off-by: David Howells <dhowells@redhat.com> cc: stable@vger.kernel.org --- arch/x86/entry/syscalls/syscall_32.tbl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea 100644 --- a/arch/x86/entry/syscalls/syscall_32.tbl +++ b/arch/x86/entry/syscalls/syscall_32.tbl @@ -294,7 +294,7 @@ # 285 sys_setaltroot 286 i386 add_key sys_add_key 287 i386 request_key sys_request_key -288 i386 keyctl sys_keyctl +288 i386 keyctl sys_keyctl compat_sys_keyctl 289 i386 ioprio_set sys_ioprio_set 290 i386 ioprio_get sys_ioprio_get 291 i386 inotify_init sys_inotify_init
[toc] | [next] | [standalone]
| From | Stephan Mueller <smueller@chronox.de> |
|---|---|
| Date | 2016-07-27 13:30 +0200 |
| Subject | Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace |
| Message-ID | <rZvce-7cz-35@gated-at.bofh.it> |
| In reply to | #1451221 |
Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells: Hi David, > x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than > calling sys_keyctl. The latter will work in a lot of cases, thereby hiding > the issue. > > Reported-by: Stephan Mueller <smueller@chronox.de> > Signed-off-by: David Howells <dhowells@redhat.com> Tested-by: Stephan Mueller <smueller@chronox.de> > cc: stable@vger.kernel.org > --- > > arch/x86/entry/syscalls/syscall_32.tbl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl > b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea > 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -294,7 +294,7 @@ > # 285 sys_setaltroot > 286 i386 add_key sys_add_key > 287 i386 request_key sys_request_key > -288 i386 keyctl sys_keyctl > +288 i386 keyctl sys_keyctl compat_sys_keyctl > 289 i386 ioprio_set sys_ioprio_set > 290 i386 ioprio_get sys_ioprio_get > 291 i386 inotify_init sys_inotify_init Ciao Stephan
[toc] | [prev] | [next] | [standalone]
| From | tip-bot for David Howells <tipbot@zytor.com> |
|---|---|
| Date | 2016-08-01 12:50 +0200 |
| Subject | [tip:x86/urgent] x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace |
| Message-ID | <s1iXf-5ai-11@gated-at.bofh.it> |
| In reply to | #1451221 |
Commit-ID: f7d665627e103e82d34306c7d3f6f46f387c0d8b Gitweb: http://git.kernel.org/tip/f7d665627e103e82d34306c7d3f6f46f387c0d8b Author: David Howells <dhowells@redhat.com> AuthorDate: Wed, 27 Jul 2016 11:42:38 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 1 Aug 2016 11:31:24 +0200 x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than calling sys_keyctl(). The latter will work in a lot of cases, thereby hiding the issue. Reported-by: Stephan Mueller <smueller@chronox.de> Tested-by: Stephan Mueller <smueller@chronox.de> Signed-off-by: David Howells <dhowells@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: keyrings@vger.kernel.org Cc: linux-security-module@vger.kernel.org Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/entry/syscalls/syscall_32.tbl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17..f848572 100644 --- a/arch/x86/entry/syscalls/syscall_32.tbl +++ b/arch/x86/entry/syscalls/syscall_32.tbl @@ -294,7 +294,7 @@ # 285 sys_setaltroot 286 i386 add_key sys_add_key 287 i386 request_key sys_request_key -288 i386 keyctl sys_keyctl +288 i386 keyctl sys_keyctl compat_sys_keyctl 289 i386 ioprio_set sys_ioprio_set 290 i386 ioprio_get sys_ioprio_get 291 i386 inotify_init sys_inotify_init
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web