Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451237

Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace

From Stephan Mueller <smueller@chronox.de>
Newsgroups linux.kernel
Subject Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace
Date 2016-07-27 13:30 +0200
Message-ID <rZvce-7cz-35@gated-at.bofh.it> (permalink)
References <rZuzv-6GJ-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells:

Hi David,

> x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> calling sys_keyctl.  The latter will work in a lot of cases, thereby hiding
> the issue.
> 
> Reported-by: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: David Howells <dhowells@redhat.com>

Tested-by: Stephan Mueller <smueller@chronox.de>

> cc: stable@vger.kernel.org
> ---
> 
>  arch/x86/entry/syscalls/syscall_32.tbl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl
> b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea
> 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -294,7 +294,7 @@
>  # 285 sys_setaltroot
>  286	i386	add_key			sys_add_key
>  287	i386	request_key		sys_request_key
> -288	i386	keyctl			sys_keyctl
> +288	i386	keyctl			sys_keyctl			compat_sys_keyctl
>  289	i386	ioprio_set		sys_ioprio_set
>  290	i386	ioprio_get		sys_ioprio_get
>  291	i386	inotify_init		sys_inotify_init



Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit  userspace David Howells <dhowells@redhat.com> - 2016-07-27 12:50 +0200
  Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace Stephan Mueller <smueller@chronox.de> - 2016-07-27 13:30 +0200
  [tip:x86/urgent] x86/syscalls/64: Add compat_sys_keyctl for 32-bit  userspace tip-bot for David Howells <tipbot@zytor.com> - 2016-08-01 12:50 +0200

csiph-web