Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451042 > unrolled thread

Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

Started byMichael Ellerman <mpe@ellerman.id.au>
First post2016-07-27 07:00 +0200
Last post2016-07-28 16:00 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Michael Ellerman <mpe@ellerman.id.au> - 2016-07-27 07:00 +0200
    RE: [PATCH 11/13] rapidio: modify for rev.3 specification changes "Wood, Barry" <Barry.Wood@idt.com> - 2016-07-27 12:40 +0200
    Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Andrew Morton <akpm@linux-foundation.org> - 2016-07-27 21:40 +0200
      Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes Michael Ellerman <mpe@ellerman.id.au> - 2016-07-28 16:00 +0200

#1451042 — Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

FromMichael Ellerman <mpe@ellerman.id.au>
Date2016-07-27 07:00 +0200
SubjectRe: [PATCH 11/13] rapidio: modify for rev.3 specification changes
Message-ID<rZp6O-3eN-5@gated-at.bofh.it>
Alexandre Bounine <alexandre.bounine@idt.com> writes:

> Implement changes made in RapidIO specification rev.3 to LP-Serial Physical
> Layer register definitions:
> - use per-port register offset calculations based on LP-Serial Extended
>   Features Block (EFB) Register Map type (I or II) with different per-port
>   offset step (0x20 vs. 0x40 respectfully).
> - remove deprecated Parallel Physical layer definitions and related code.
>
> Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
> Tested-by: Barry Wood <barry.wood@idt.com>
> Cc: Matt Porter <mporter@kernel.crashing.org>
> Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
> Cc: Barry Wood <barry.wood@idt.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/rapidio/devices/rio_mport_cdev.c |    2 +-
>  drivers/rapidio/devices/tsi721.c         |    8 +-
>  drivers/rapidio/rio-scan.c               |   74 +++----------
>  drivers/rapidio/rio.c                    |  149 ++++++++++++++-------------
>  drivers/rapidio/rio.h                    |    2 +-
>  drivers/rapidio/switches/tsi57x.c        |   26 ++---
>  include/linux/rio.h                      |   11 +--
>  include/linux/rio_regs.h                 |  167 +++++++++++++++++++++++------
>  8 files changed, 248 insertions(+), 191 deletions(-)

This is breaking the build for me on powerpc, for
corenet64_smp_defconfig at least.

eg.

http://kisskb.ellerman.id.au/kisskb/buildresult/12750751/

Commit:   Add linux-next specific files for 20160722
	  13123042d0dbf7635f052efc2ae69fd9af624f1d
Compiler: powerpc-linux-gcc (GCC) 4.6.3

Possible errors
---------------

arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
make[2]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1
make[1]: *** [arch/powerpc/sysdev] Error 2
make: *** [sub-make] Error 2

cheers

[toc] | [next] | [standalone]

#1451214

From"Wood, Barry" <Barry.Wood@idt.com>
Date2016-07-27 12:40 +0200
Message-ID<rZupP-6Bc-7@gated-at.bofh.it>
In reply to#1451042
Hi Michael,

Alex is currently on vacation, but will return August 2.  He will resolve this issue at that time.

Cheers,
Barry

-----Original Message-----
From: Michael Ellerman [mailto:mpe@ellerman.id.au] 
Sent: Wednesday, July 27, 2016 12:53 AM
To: Bounine, Alexandre; Andrew Morton
Cc: Bounine, Alexandre; Matt Porter; Andre van Herk; Wood, Barry; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

Alexandre Bounine <alexandre.bounine@idt.com> writes:

> Implement changes made in RapidIO specification rev.3 to LP-Serial 
> Physical Layer register definitions:
> - use per-port register offset calculations based on LP-Serial Extended
>   Features Block (EFB) Register Map type (I or II) with different per-port
>   offset step (0x20 vs. 0x40 respectfully).
> - remove deprecated Parallel Physical layer definitions and related code.
>
> Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
> Tested-by: Barry Wood <barry.wood@idt.com>
> Cc: Matt Porter <mporter@kernel.crashing.org>
> Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
> Cc: Barry Wood <barry.wood@idt.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/rapidio/devices/rio_mport_cdev.c |    2 +-
>  drivers/rapidio/devices/tsi721.c         |    8 +-
>  drivers/rapidio/rio-scan.c               |   74 +++----------
>  drivers/rapidio/rio.c                    |  149 ++++++++++++++-------------
>  drivers/rapidio/rio.h                    |    2 +-
>  drivers/rapidio/switches/tsi57x.c        |   26 ++---
>  include/linux/rio.h                      |   11 +--
>  include/linux/rio_regs.h                 |  167 +++++++++++++++++++++++------
>  8 files changed, 248 insertions(+), 191 deletions(-)

This is breaking the build for me on powerpc, for corenet64_smp_defconfig at least.

eg.

http://kisskb.ellerman.id.au/kisskb/buildresult/12750751/

Commit:   Add linux-next specific files for 20160722
	  13123042d0dbf7635f052efc2ae69fd9af624f1d
Compiler: powerpc-linux-gcc (GCC) 4.6.3

Possible errors
---------------

arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
make[2]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1
make[1]: *** [arch/powerpc/sysdev] Error 2
make: *** [sub-make] Error 2

cheers

[toc] | [prev] | [next] | [standalone]

#1451485

FromAndrew Morton <akpm@linux-foundation.org>
Date2016-07-27 21:40 +0200
Message-ID<rZCQp-3GO-19@gated-at.bofh.it>
In reply to#1451042
On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:

> Alexandre Bounine <alexandre.bounine@idt.com> writes:
> 
> > Implement changes made in RapidIO specification rev.3 to LP-Serial Physical
> > Layer register definitions:
> > - use per-port register offset calculations based on LP-Serial Extended
> >   Features Block (EFB) Register Map type (I or II) with different per-port
> >   offset step (0x20 vs. 0x40 respectfully).
> > - remove deprecated Parallel Physical layer definitions and related code.
> >
> > Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
> > Tested-by: Barry Wood <barry.wood@idt.com>
> > Cc: Matt Porter <mporter@kernel.crashing.org>
> > Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
> > Cc: Barry Wood <barry.wood@idt.com>
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  drivers/rapidio/devices/rio_mport_cdev.c |    2 +-
> >  drivers/rapidio/devices/tsi721.c         |    8 +-
> >  drivers/rapidio/rio-scan.c               |   74 +++----------
> >  drivers/rapidio/rio.c                    |  149 ++++++++++++++-------------
> >  drivers/rapidio/rio.h                    |    2 +-
> >  drivers/rapidio/switches/tsi57x.c        |   26 ++---
> >  include/linux/rio.h                      |   11 +--
> >  include/linux/rio_regs.h                 |  167 +++++++++++++++++++++++------
> >  8 files changed, 248 insertions(+), 191 deletions(-)
> 
> This is breaking the build for me on powerpc, for
> corenet64_smp_defconfig at least.
> 
> eg.
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12750751/
> 
> Commit:   Add linux-next specific files for 20160722
> 	  13123042d0dbf7635f052efc2ae69fd9af624f1d
> Compiler: powerpc-linux-gcc (GCC) 4.6.3
> 
> Possible errors
> ---------------
> 
> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
> make[2]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1
> make[1]: *** [arch/powerpc/sysdev] Error 2
> make: *** [sub-make] Error 2

I'll go out on a limb and assume it's this:

--- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix
+++ a/arch/powerpc/sysdev/fsl_rio.c
@@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device
 			RIO_INB_ATMU_REGS_PORT2_OFFSET));
 
 
-		/* Set to receive any dist ID for serial RapidIO controller. */
-		if (port->phy_type == RIO_PHY_SERIAL)
-			out_be32((priv->regs_win
-				+ RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA);
-
 		/* Configure maintenance transaction window */
 		out_be32(&priv->maint_atmu_regs->rowbar,
 			port->iores.start >> 12);
_

[toc] | [prev] | [next] | [standalone]

#1451940

FromMichael Ellerman <mpe@ellerman.id.au>
Date2016-07-28 16:00 +0200
Message-ID<rZU0V-70m-5@gated-at.bofh.it>
In reply to#1451485
Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
>> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
>
> I'll go out on a limb and assume it's this:
>
> --- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix
> +++ a/arch/powerpc/sysdev/fsl_rio.c
> @@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device
>  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
>  
>  
> -		/* Set to receive any dist ID for serial RapidIO controller. */
> -		if (port->phy_type == RIO_PHY_SERIAL)
> -			out_be32((priv->regs_win
> -				+ RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA);
> -

Yep, thanks.

Hopefully someone somewhere is testing this on powerpc, I don't have one
of those FSL boxes. But at least it will build now.

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web